[release-25.05] signal-desktop.webrtc: use gn_2233 to unbreak#419048
Merged
emilylange merged 2 commits intoNixOS:release-25.05from Jun 22, 2025
Merged
[release-25.05] signal-desktop.webrtc: use gn_2233 to unbreak#419048emilylange merged 2 commits intoNixOS:release-25.05from
emilylange merged 2 commits intoNixOS:release-25.05from
Conversation
marcin-serwin
changed the title
gn for signal-desktopgn for signal-desktop
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
github-actions
bot
added
10.rebuild-linux: 1-10
emilylange
requested changes
Jun 22, 2025
Member
emilylange
left a comment
emilylange
left a comment
There was a problem hiding this comment.
Can you please also extend your commit message to contain the motivation for those changes?
It does not have to be much, just something like "Init as new variant of gn because the current version is too old for signal-desktop's webrtc fork and we don't want to update gn on stable" and "to unbreak build because gn is too old".
Init as new variant of gn because the current version is too old for signal-desktop's webrtc fork and we don't want to update gn on stable. Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Default gn on stable is too old. Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-xnovpnokxxyq
branch
from
7bebb24 to
899cd21
Compare
github-actions
bot
added
the
11.by: package-maintainer
emilylange
dismissed
github-actions[bot]’s stale review
If you need to merge this PR despite the warnings, please dismiss this review.
emilylange
approved these changes
Jun 22, 2025
emilylange
changed the title
gn for signal-desktop
github-actions
bot
added
the
12.approvals: 1
Member
# git log --oneline -n 3
7bcd08c98796 (HEAD) Merge 899cd214d943ee7fc18a0f4278da06307964bb81 into c7ab75210cb8cb16ddd8f290755d9558edde7ee1
899cd214d943 signal-desktop.webrtc: use gn_2233 to unbreak
a4a1a0c1348c gn_2233: init
# nix-build -A signal-desktop.tests --system x86_64-linux
/nix/store/kbvwdjxb9rg2vb1dyghbjzp47vpd4l39-vm-test-run-signal-desktop
# nix-build -A signal-desktop.tests --system aarch64-linux
/nix/store/gmj57jykg7bxp1n2w8ydd0f4wg06gn6m-vm-test-run-signal-desktop |
3 tasks
3 tasks
3 tasks
justrowingby
added a commit
to justrowingby/dotfiles
that referenced
this pull request
Jun 24, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days due to a nixpkgs committer merging signal version bump backport without waiting for CI to pass. a fix was merged just 2 days later, which was 2 days ago, but hasnt passed hydra and moved from release-25.05 to nixos-25.05 yet. bad merge: NixOS/nixpkgs#418529 fix merge: NixOS/nixpkgs#419048 my temp fix for this is to specify stable's exact commit in flake.nix, to a commit shortly before the signal version bump backport. i would like to remove the commit spec as soon as nixos-25.05 gets the right commit to not break me. otherwise, seemingly smooth update.
|
Does this need porting to nixos-unstable? |
Contributor
Author
No, on nixos-unstable it already uses the newer |
justrowingby
added a commit
to justrowingby/dotfiles
that referenced
this pull request
Nov 28, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days due to a nixpkgs committer merging signal version bump backport without waiting for CI to pass. a fix was merged just 2 days later, which was 2 days ago, but hasnt passed hydra and moved from release-25.05 to nixos-25.05 yet. bad merge: NixOS/nixpkgs#418529 fix merge: NixOS/nixpkgs#419048 my temp fix for this is to specify stable's exact commit in flake.nix, to a commit shortly before the signal version bump backport. i would like to remove the commit spec as soon as nixos-25.05 gets the right commit to not break me. otherwise, seemingly smooth update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #419018
fixes #418971
cc @emilylange @drupol
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.