[Backport release-25.05] signal-desktop: 7.56.1 -> 7.58.0#418529
Merged
drupol merged 1 commit intorelease-25.05from Jun 20, 2025
Merged
[Backport release-25.05] signal-desktop: 7.56.1 -> 7.58.0#418529drupol merged 1 commit intorelease-25.05from
drupol merged 1 commit intorelease-25.05from
Conversation
Signed-off-by: Marcin Serwin <marcin@serwin.dev> (cherry picked from commit 63b6e30)
Member
|
Why didn't you wait for CI before merging here? |
Contributor
|
Feel free to merge the revert if this issue is still there. |
Contributor
|
FYI, the issue has been reported here: #418971 |
Member
|
@drupol you haven't answered why you didn't wait for CI yet. Please explain. |
Contributor
|
Oh fair point. I figured the revert PR was the answer, a kind of "oops, my bad" in code form. I didn’t mean to ignore the question, just thought actions speak louder than explanations sometimes. I merged the PR because I am used to merge |
justrowingby
added a commit
to justrowingby/dotfiles
that referenced
this pull request
Jun 24, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days due to a nixpkgs committer merging signal version bump backport without waiting for CI to pass. a fix was merged just 2 days later, which was 2 days ago, but hasnt passed hydra and moved from release-25.05 to nixos-25.05 yet. bad merge: NixOS/nixpkgs#418529 fix merge: NixOS/nixpkgs#419048 my temp fix for this is to specify stable's exact commit in flake.nix, to a commit shortly before the signal version bump backport. i would like to remove the commit spec as soon as nixos-25.05 gets the right commit to not break me. otherwise, seemingly smooth update.
justrowingby
added a commit
to justrowingby/dotfiles
that referenced
this pull request
Nov 28, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days due to a nixpkgs committer merging signal version bump backport without waiting for CI to pass. a fix was merged just 2 days later, which was 2 days ago, but hasnt passed hydra and moved from release-25.05 to nixos-25.05 yet. bad merge: NixOS/nixpkgs#418529 fix merge: NixOS/nixpkgs#419048 my temp fix for this is to specify stable's exact commit in flake.nix, to a commit shortly before the signal version bump backport. i would like to remove the commit spec as soon as nixos-25.05 gets the right commit to not break me. otherwise, seemingly smooth update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #418479.