Skip to content

[Backport release-25.05] signal-desktop: 7.56.1 -> 7.58.0#418529

Merged
drupol merged 1 commit intorelease-25.05from
backport-418479-to-release-25.05
Jun 20, 2025
Merged

[Backport release-25.05] signal-desktop: 7.56.1 -> 7.58.0#418529
drupol merged 1 commit intorelease-25.05from
backport-418479-to-release-25.05

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jun 20, 2025

Bot-based backport to release-25.05, triggered by a label in #418479.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
(cherry picked from commit 63b6e30)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 20, 2025
13 tasks
@drupol drupol merged commit ec561e7 into release-25.05 Jun 20, 2025
15 of 17 checks passed
@drupol drupol deleted the backport-418479-to-release-25.05 branch June 20, 2025 20:29
@mweinelt
Copy link
Member

Why didn't you wait for CI before merging here?

signal-webrtc> Running phase: configurePhase
signal-webrtc> gn flags: target_os=\"linux\" use_sysroot=false is_clang=false treat_warnings_as_errors=false rtc_build_examples=false rtc_build_tools=false rtc_use_x11=false rtc_enable_sctp=false rtc_libvpx_build_vp9=true rtc_disable_metrics=true rtc_disable_trace_events=true is_debug=false symbol_level=1 rtc_include_tests=false rtc_enable_protobuf=false rust_sysroot_absolute=\"/nix/store/9bc93rjal0wmb7cc5j0c94k5dfl2axiz-rustc-wrapper-1.86.0\"
signal-webrtc> ERROR at //build/toolchain/siso.gni:10:5: Unknown function.
signal-webrtc> if (path_exists("/usr/bin/gcert") ||  # linux
signal-webrtc>     ^----------
signal-webrtc> See //build/toolchain/rbe.gni:8:1: whence it was imported.
signal-webrtc> import("//build/toolchain/siso.gni")
signal-webrtc> ^----------------------------------
signal-webrtc> See //build/config/linux/pkg_config.gni:6:1: whence it was imported.
signal-webrtc> import("//build/toolchain/rbe.gni")
signal-webrtc> ^---------------------------------
signal-webrtc> See //BUILD.gn:24:1: whence it was imported.
signal-webrtc> import("//build/config/linux/pkg_config.gni")
signal-webrtc> ^-------------------------------------------
signal-webrtc> 

@drupol
Copy link
Contributor

drupol commented Jun 22, 2025

Feel free to merge the revert if this issue is still there.

@marcin-serwin
Copy link
Contributor

FYI, the issue has been reported here: #418971

@emilylange
Copy link
Member

@drupol you haven't answered why you didn't wait for CI yet. Please explain.

@drupol
Copy link
Contributor

drupol commented Jun 22, 2025

Oh fair point. I figured the revert PR was the answer, a kind of "oops, my bad" in code form. I didn’t mean to ignore the question, just thought actions speak louder than explanations sometimes.

I merged the PR because I am used to merge signal-desktop since quite a while, and it's usually a very stable derivation. I guess I didn't wait for the end because it was stuck or too long? I usually wait for at least one build before pressing the merge button, I don't really remember why I did not in this case.

justrowingby added a commit to justrowingby/dotfiles that referenced this pull request Jun 24, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days
due to a nixpkgs committer merging signal version bump backport
without waiting for CI to pass. a fix was merged just 2 days later,
which was 2 days ago, but hasnt passed hydra and moved from
release-25.05 to nixos-25.05 yet.

bad merge: NixOS/nixpkgs#418529
fix merge: NixOS/nixpkgs#419048

my temp fix for this is to specify stable's exact commit in flake.nix,
to a commit shortly before the signal version bump backport. i would
like to remove the commit spec as soon as nixos-25.05 gets the right
commit to not break me.

otherwise, seemingly smooth update.
justrowingby added a commit to justrowingby/dotfiles that referenced this pull request Nov 28, 2025
currently the nixos-25.05 has broken signal-desktop for a couple days
due to a nixpkgs committer merging signal version bump backport
without waiting for CI to pass. a fix was merged just 2 days later,
which was 2 days ago, but hasnt passed hydra and moved from
release-25.05 to nixos-25.05 yet.

bad merge: NixOS/nixpkgs#418529
fix merge: NixOS/nixpkgs#419048

my temp fix for this is to specify stable's exact commit in flake.nix,
to a commit shortly before the signal version bump backport. i would
like to remove the commit spec as soon as nixos-25.05 gets the right
commit to not break me.

otherwise, seemingly smooth update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants