Skip to content

treewide: replace pname with string literal#417886

Merged
pbsds merged 1 commit intoNixOS:masterfrom
guylamar2006:hardcode-pname-2
Jun 19, 2025
Merged

treewide: replace pname with string literal#417886
pbsds merged 1 commit intoNixOS:masterfrom
guylamar2006:hardcode-pname-2

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jun 18, 2025

replace pname with string literal

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 18, 2025
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 417886

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/15736599530

@pbsds
Copy link
Member

pbsds commented Jun 19, 2025

tested with nix-build ... --check:

scripted:

cargo-llvm-cov.src
cargo-xbuild.src
defaultbrowser.src
dep-tree.src
duti.src
git-machete.src
gnome-session-ctl.src
graphite-gtk-theme.src
gtk-mac-integration-gtk2.src
gtk-mac-integration-gtk3.src
gtk-mac-integration.src
holo-build.src
kanidm.src
kanidmWithSecretProvisioning.src
kanidmWithSecretProvisioning_1_4.src
kanidmWithSecretProvisioning_1_5.src
kanidmWithSecretProvisioning_1_6.src
kanidm_1_4.src
kanidm_1_5.src
kanidm_1_6.src
kddockwidgets.src
libcrossguid.src
m-cli.src
matcha-gtk-theme.src
mlxbf-bootctl.src
nix-template.src
os-prober.src
osx-cpu-temp.src
pam-reattach.src
poetryPlugins.poetry-plugin-export.src
poetryPlugins.poetry-plugin-up.src
pulseaudio-ctl.src
pulseaudio-module-xrdp.src
qogir-theme.src
quickwit.src
reversal-icon-theme.src
scenic-view.src
sierra-gtk-theme.src
spacebar.src
tracee.src

special cases

clps2c-compiler.srcs
keeperrl.srcs
mojave-gtk-theme.srcs
ocf-resource-agents.inputs.resource-agentsForOCF.src
sing-geoip.generator.src

diff only:

nvidia-docker
photoprism

@pbsds
Copy link
Member

pbsds commented Jun 19, 2025

if you had adapted the script in #413122 this would've required less manual checking, but LGTM

@pbsds pbsds merged commit 01f1195 into NixOS:master Jun 19, 2025
27 of 28 checks passed
@guylamar2006 guylamar2006 deleted the hardcode-pname-2 branch June 19, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants