treewide: substitute finalAttrs.pname for strings#413122
Merged
drupol merged 1 commit intoNixOS:masterfrom Jun 2, 2025
Merged
Conversation
ghost
approved these changes
Jun 2, 2025
13 tasks
drupol
approved these changes
Jun 2, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #410679, this time targeting
finalAttrs.pname. Limited topkgs/by-name, part of #346453I widened the grep to allow for more patterns where
finalAttrs.pnameare used.Should be zero rebuilds.
All candidates were made using:
diff packages{,2}.jsonis empty, indicating that no package nor src derivation has changed, nor have I introduced any eval failures.I checked and cherry-picked the changes using
GIT_DIFF_OPTS='-u20' git -c interactive.singleKey=true add --patchalong to some music. I then tested merging against master, staging and staging-nextThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.