Skip to content

nodejs_20: use stable URL for GYP patches#417612

Merged
FliegendeWurst merged 1 commit intoNixOS:stagingfrom
aduh95:stable-gyp-patches
Jun 17, 2025
Merged

nodejs_20: use stable URL for GYP patches#417612
FliegendeWurst merged 1 commit intoNixOS:stagingfrom
aduh95:stable-gyp-patches

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 17, 2025 •
edited by FliegendeWurst
Loading

Refs: #416077 (comment)

ref. #257446

Closes #417447

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 requested a review from FliegendeWurst June 17, 2025 17:10
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jun 17, 2025

LGTM, needs a nixfmt run.

Certainly a nicer solution than my #417447 (btw, are you not listed as nodejs_20 maintainer?)

@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Jun 17, 2025
@drupol
Copy link
Contributor

drupol commented Jun 17, 2025

Is it related to #417447 ?

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jun 17, 2025

It is pretty much the same

@aduh95 aduh95 force-pushed the stable-gyp-patches branch from 38e5f40 to 89d3d5b Compare June 17, 2025 19:02
drupol
drupol reviewed Jun 17, 2025
View reviewed changes
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 17, 2025

btw, are you not listed as nodejs_20 maintainer?

I think I am, not sure what's up with it 🤷‍♂️

Is it related to #417447 ?

Sorry I missed that one – I don't mind either one landing

@aduh95 aduh95 force-pushed the stable-gyp-patches branch from 89d3d5b to 998e9f0 Compare June 17, 2025 19:07
@drupol
Copy link
Contributor

drupol commented Jun 17, 2025

Can we close this one then?

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jun 17, 2025

Can we close this one then?

This one is better, since it deduplicates the patch used in nodejs_22.

@FliegendeWurst FliegendeWurst merged commit 00dd7a7 into NixOS:staging Jun 17, 2025
13 of 16 checks passed
@aduh95 aduh95 deleted the stable-gyp-patches branch June 17, 2025 20:59
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 19, 2025

Successfully created backport PR for staging-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 19, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol left review comments

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @FliegendeWurst @drupol