nodejs_22: re-add patch to fix sandboxed builds using gyp on Darwin#416077
nodejs_22: re-add patch to fix sandboxed builds using gyp on Darwin#416077FliegendeWurst merged 1 commit intoNixOS:stagingfrom
Conversation
|
nit: it might be better to refactor I'm able to build this when rebased on top of |
pkgs/development/web/nodejs/v22.nix
Outdated
There was a problem hiding this comment.
| url = "https://github.com/nodejs/gyp-next/commit/706d04aba5bd18f311dc56f84720e99f64c73466.patch"; | |
| url = "https://github.com/nodejs/gyp-next/commit/706d04aba5bd18f311dc56f84720e99f64c73466.patch?full_index=1"; |
Or use the old fetchpatch. #257446
There was a problem hiding this comment.
FWIW it's unlikely to actually cause problems given the low activity on nodejs/gyp-next – but sure, let's fix it. gyp-patches.nix has the same issue btw:
There was a problem hiding this comment.
I'll fix gyp-patches.nix.
FWIW it's unlikely to actually cause problems given the low activity on nodejs/gyp-next
It is possible to break the hash with some targeted commits in a fork, I think. (Though I really doubt anyone would try to ...)
There was a problem hiding this comment.
I committed the fix here
a150388 to
f0b3061
Compare
|
Successfully created backport PR for |
Fixes a regression introduced by #349157, which removed
gypPatchesfor nodejs_22.As was noted in the past, for some reason Node.js v22 vendors two different gyp versions:
v22.10.0 updated gyp in the former directory, making the patch in question obsolete. However, the latter vendored gyp still needs to be patched.
Apart from some flaky checks that seem unrelated to me, I've successfully tested building nodejs_22 and a yarn-berry package I'm working on, which failed before.
Maintainer ping: @aduh95
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.