Skip to content

gnum4: 1.4.19 -> 1.4.20 (take 2)#417460

Merged
pbsds merged 2 commits intoNixOS:stagingfrom
trofi:gnum4-update
Jun 19, 2025
Merged

gnum4: 1.4.19 -> 1.4.20 (take 2)#417460
pbsds merged 2 commits intoNixOS:stagingfrom
trofi:gnum4-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jun 17, 2025

Changes: https://lists.gnu.org/archive/html/m4-announce/2025-05/msg00000.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@trofi trofi mentioned this pull request Jun 17, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 17, 2025
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good afternoon, i guess

Co-authored-by: Acid Bong <acidbong@tilde.club>
@trofi
Copy link
Contributor Author

trofi commented Jun 18, 2025

Pushed finalAttrs suggested changes as a separate commit as:

--- a/pkgs/by-name/gn/gnum4/package.nix
+++ b/pkgs/by-name/gn/gnum4/package.nix
@@ -9,12 +9,12 @@
 # cgit) that are needed here should be included directly in Nixpkgs as
 # files.

-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "gnum4";
   version = "1.4.20";

   src = fetchurl {
-    url = "mirror://gnu/m4/m4-${version}.tar.bz2";
+    url = "mirror://gnu/m4/m4-${finalAttrs.version}.tar.bz2";
     hash = "sha256-rGmJ7l0q7YFzl4BjDMLOCX4qZUb+uWpKVNs31GoUUuQ=";
   };

@@ -68,4 +68,4 @@ stdenv.mkDerivation rec {
     platforms = lib.platforms.unix ++ lib.platforms.windows;
   };

-}
+})

@trofi trofi requested a review from acid-bong June 18, 2025 07:51
@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 18, 2025
@pbsds
Copy link
Member

pbsds commented Jun 19, 2025

darwin ofborg timed out before reaching stdenv, but i managed to build it when cherry-picked into master:

image

Lets try 🤞 :shipit:

@pbsds pbsds merged commit ac21e3a into NixOS:staging Jun 19, 2025
15 of 16 checks passed
@trofi trofi deleted the gnum4-update branch June 19, 2025 22:48
@alyssais
Copy link
Member

alyssais commented Jun 22, 2025

Broke musl. I'm proposing fixing the underlying issue rather than disabling the error in #418934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants