Skip to content

gnum4: 1.4.19 -> 1.4.20#416046

Merged
pbsds merged 1 commit intoNixOS:stagingfrom
trofi:gnum4-update
Jun 17, 2025
Merged

gnum4: 1.4.19 -> 1.4.20#416046
pbsds merged 1 commit intoNixOS:stagingfrom
trofi:gnum4-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jun 12, 2025

Changes: https://lists.gnu.org/archive/html/m4-announce/2025-05/msg00000.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 12, 2025
@pbsds pbsds merged commit 0b31333 into NixOS:staging Jun 17, 2025
17 of 18 checks passed
@trofi trofi deleted the gnum4-update branch June 17, 2025 04:46
@vcunat
Copy link
Member

vcunat commented Jun 17, 2025

This broke darwin stdenv!
https://hydra.nixos.org/build/300264726/nixlog/3/tail

@pbsds
Copy link
Member

pbsds commented Jun 17, 2025

@pbsds
Copy link
Member

pbsds commented Jun 17, 2025

Hmm, I assume I must have confused the tail in https://github.com/NixOS/nixpkgs/runs/43995271425 with some other staging PR tab i had open where I already had checked ofborg to find that the builder had timed out. The fact that the 10.rebuild-darwin-stdenv label is missing did not help either.

Skimming through ci/eval/compare/default.nix it should've been added however. @vcunat have CI been adding that tag correctly since eval transitioned to GHA?

@trofi
Copy link
Contributor Author

trofi commented Jun 17, 2025

clean-temp.c:235:14: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]

@trofi
Copy link
Contributor Author

trofi commented Jun 17, 2025

Trying again:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants