workflows/labels: fix approval label with maintainers#416739
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jun 14, 2025
Merged
workflows/labels: fix approval label with maintainers#416739wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
This currently fails with: ``` Method Set.prototype.has called on incompatible receiver undefined ``` Seems like my syntax test previously only hit the case without maintainers, in which case it doesn't throw :/.
Contributor
Author
|
Merging immediately, because the labels workflows currently fails in a lot of cases. |
2 tasks
github-actions
bot
added
10.rebuild-darwin: 0
wolfgangwalther
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently fails with:
Seems like my syntax test previously only hit the case without maintainers, in which case it doesn't throw :/.
The reason why this fails is explained here: https://stackoverflow.com/a/51849963
Things done
Add a 👍 reaction to pull requests you find important.