workflows/labels: count approving reviewers, not reviews#416668
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jun 14, 2025
Merged
workflows/labels: count approving reviewers, not reviews#416668wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
A single reviewer approving a Pull Request multiple times should only count once.
wolfgangwalther
force-pushed
the
ci-fix-approvals
branch
from
0afe16f to
2e03351
Compare
github-actions
bot
added
the
12.approvals: 1
MattSturgeon
approved these changes
Jun 14, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-416668-to-release-24.11 origin/release-24.11
cd .worktree/backport-416668-to-release-24.11
git switch --create backport-416668-to-release-24.11
git cherry-pick -x 2e033512487f35ea755c8a42116c420568b8e14c |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-416668-to-release-25.05 origin/release-25.05
cd .worktree/backport-416668-to-release-25.05
git switch --create backport-416668-to-release-25.05
git cherry-pick -x 2e033512487f35ea755c8a42116c420568b8e14c |
wolfgangwalther
added
the
8.has: port to stable
Contributor
Author
Contributor
Author
|
Unfortunately this failed for PRs with maintainers, so I quick-merged a fix in #416739. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single reviewer approving a Pull Request multiple times should only count once.
Example: #416076 - two approvals by make-42 resulted in an
approvals: 2label.Things done
Add a 👍 reaction to pull requests you find important.