Skip to content

uae: drop#415956

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-uae
Jun 17, 2025
Merged

uae: drop#415956
Aleksanaa merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-uae

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jun 11, 2025 •
edited
Loading

Unmaintained upstream, unused, broken with gcc 14, and replaced by fsuae.

Cc maintainer: @svanderburg

Closes: #415052 (prior PR, where removal was suggested)
Tracking: #388196 #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757
uae: drop
30019ca 
Unmaintained, unused, broken with gcc 14, and replaced by fsuae.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 11, 2025
@Sigmanificient Sigmanificient mentioned this pull request Jun 12, 2025
Open
28 tasks
@Aleksanaa Aleksanaa requested a review from svanderburg June 12, 2025 02:25
Aleksanaa
Aleksanaa approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for approval from @svanderburg

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 13, 2025
@Aleksanaa Aleksanaa merged commit 33ced05 into NixOS:master Jun 17, 2025
21 of 22 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 17, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 17, 2025
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 17, 2025
Merged
1 task
@mdaniels5757 mdaniels5757 deleted the drop-uae branch June 17, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdaniels5757 @Aleksanaa @wegank