Skip to content

uae: unbreak#415052

Closed
petrzjunior wants to merge 1 commit intoNixOS:masterfrom
petrzjunior:uae
Closed

uae: unbreak#415052
petrzjunior wants to merge 1 commit intoNixOS:masterfrom
petrzjunior:uae

Conversation

@petrzjunior
Copy link
Contributor

Unbreak uae on GCC 14. The package is unmaintained and pulled from archive.org, but the compilation works with a few flags disabled. Ideally we should package some modern fork (such as FS-UAE) and drop this.

I tested that the program starts on x86_64-linux, did not try any functionality.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2025
@nix-owners nix-owners bot requested a review from svanderburg June 8, 2025 16:04
@petrzjunior
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 415052

Logs: https://github.com/petrzjunior/nixpkgs-review-gha/actions/runs/15520189565


x86_64-linux (sandbox = true)

✅ 1 package built:
  • uae

aarch64-linux (sandbox = true)

✅ 1 package built:
  • uae

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415052
Commit: 71e54c6b416facf77bef1aa293c6245e5459bfb8


x86_64-linux

✅ 1 package built:
  • uae

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 9, 2025
@mdaniels5757
Copy link
Member

Unbreak uae on GCC 14. The package is unmaintained and pulled from archive.org, but the compilation works with a few flags disabled. Ideally we should package some modern fork (such as FS-UAE) and drop this.

It looks like we do package FS-UAE (link), and it seems that no package depends on this one. So perhaps we can just drop this?

@Aleksanaa
Copy link
Member

Yes, just drop this then.

@mdaniels5757 mdaniels5757 mentioned this pull request Jun 11, 2025
13 tasks
@petrzjunior petrzjunior deleted the uae branch June 13, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants