Skip to content

libretro.mkLibretroCore: switch to lib.extendMkDerivation#415870

Merged
thiagokokada merged 3 commits intoNixOS:masterfrom
thiagokokada:libretro-use-extendMkDerivation
Jun 12, 2025
Merged

libretro.mkLibretroCore: switch to lib.extendMkDerivation#415870
thiagokokada merged 3 commits intoNixOS:masterfrom
thiagokokada:libretro-use-extendMkDerivation

Conversation

@thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jun 11, 2025

Switch mkLibretroCore to use #234651.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@thiagokokada thiagokokada force-pushed the libretro-use-extendMkDerivation branch from dbd707a to 1590c19 Compare June 11, 2025 14:29
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 11, 2025
@nix-owners nix-owners bot requested review from aanderse, edwtjo and hrdinka June 11, 2025 14:34
@thiagokokada

This comment was marked as outdated.

@thiagokokada thiagokokada force-pushed the libretro-use-extendMkDerivation branch from 1590c19 to 3ffe9fb Compare June 11, 2025 18:35
@thiagokokada
Copy link
Contributor Author

@ofborg build retroarch-free

@thiagokokada

This comment was marked as outdated.

@thiagokokada
Copy link
Contributor Author

CC @aanderse for review.

@thiagokokada thiagokokada force-pushed the libretro-use-extendMkDerivation branch from 3ffe9fb to e136add Compare June 11, 2025 20:13
@thiagokokada
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415870
Commit: e136add11987a51e456fc5d905087908c7744e0d


x86_64-linux

✅ 112 packages built:
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-gw
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • libretro.atari800
  • libretro.beetle-gba
  • libretro.beetle-lynx
  • libretro.beetle-ngp
  • libretro.beetle-pce
  • libretro.beetle-pce-fast
  • libretro.beetle-pcfx
  • libretro.beetle-psx
  • libretro.beetle-psx-hw
  • libretro.beetle-saturn
  • libretro.beetle-supafaust
  • libretro.beetle-supergrafx
  • libretro.beetle-vb
  • libretro.beetle-wswan
  • libretro.blastem
  • libretro.bluemsx
  • libretro.bsnes
  • libretro.bsnes-hd
  • libretro.bsnes-mercury
  • libretro.bsnes-mercury-balanced
  • libretro.bsnes-mercury-performance
  • libretro.citra
  • libretro.desmume
  • libretro.desmume2015
  • libretro.dolphin
  • libretro.dosbox
  • libretro.dosbox-pure
  • libretro.easyrpg
  • libretro.eightyone
  • libretro.fbalpha2012
  • libretro.fbneo
  • libretro.fceumm
  • libretro.flycast
  • libretro.fmsx
  • libretro.freeintv
  • libretro.fuse
  • libretro.gambatte
  • libretro.genesis-plus-gx
  • libretro.gpsp
  • libretro.gw
  • libretro.handy
  • libretro.hatari
  • libretro.mame
  • libretro.mame2000
  • libretro.mame2003
  • libretro.mame2003-plus
  • libretro.mame2010
  • libretro.mame2015
  • libretro.mame2016
  • libretro.melonds
  • libretro.mesen
  • libretro.mesen-s
  • libretro.meteor
  • libretro.mgba
  • libretro.mrboom
  • libretro.mupen64plus
  • libretro.neocd
  • libretro.nestopia
  • libretro.np2kai
  • libretro.nxengine
  • libretro.o2em
  • libretro.opera
  • libretro.parallel-n64
  • libretro.pcsx-rearmed (libretro.pcsx_rearmed)
  • libretro.pcsx2
  • libretro.picodrive
  • libretro.play
  • libretro.ppsspp
  • libretro.prboom
  • libretro.prosystem
  • libretro.puae
  • libretro.quicknes
  • libretro.same_cdi
  • libretro.sameboy
  • libretro.scummvm
  • libretro.smsplus-gx
  • libretro.snes9x
  • libretro.snes9x2002
  • libretro.snes9x2005
  • libretro.snes9x2005-plus
  • libretro.snes9x2010
  • libretro.stella
  • libretro.stella2014
  • libretro.swanstation
  • libretro.tgbdual
  • libretro.thepowdertoy
  • libretro.tic80
  • libretro.twenty-fortyeight
  • libretro.vba-m
  • libretro.vba-next
  • libretro.vecx
  • libretro.vice-x128
  • libretro.vice-x64
  • libretro.vice-x64dtv
  • libretro.vice-x64sc
  • libretro.vice-xcbm2
  • libretro.vice-xcbm5x0
  • libretro.vice-xpet
  • libretro.vice-xplus4
  • libretro.vice-xscpu64
  • libretro.vice-xvic
  • libretro.virtualjaguar
  • libretro.yabause
  • retroarch-free
  • retroarch-full

@thiagokokada thiagokokada merged commit 9c13281 into NixOS:master Jun 12, 2025
16 of 18 checks passed
@thiagokokada thiagokokada deleted the libretro-use-extendMkDerivation branch June 12, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants