Skip to content

pub2nix.generators.linkPackageConfig: set languageVersion for root package#422970

Merged
philiptaron merged 1 commit intomasterfrom
unknown repository
Jul 10, 2025
Merged

pub2nix.generators.linkPackageConfig: set languageVersion for root package#422970
philiptaron merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 6, 2025

Resolves #414170

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from philiptaron July 6, 2025 16:25
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jul 6, 2025
philiptaron
philiptaron reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know too much about Dart, but here are some thoughts.

@philiptaron philiptaron requested a review from hacker1024 July 7, 2025 13:15
@philiptaron
Copy link
Contributor

philiptaron commented Jul 7, 2025

Added @hacker1024 as they were the originator of the issue and likely understand Dart better.

@ghost ghost requested a review from philiptaron July 10, 2025 13:37
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 10, 2025
@philiptaron

This comment was marked as outdated.

Sign in to view
@philiptaron
Copy link
Contributor

philiptaron commented Jul 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422970
Commit: cf57cdeb3b8be7d8ab2efc0c93eefd84d39f1f95

x86_64-linux

❌ 6 packages failed to build:
  • expidus.calculator
  • expidus.calculator.debug
  • expidus.calculator.pubcache
  • expidus.file-manager
  • expidus.file-manager.debug
  • expidus.file-manager.pubcache
✅ 185 packages built:
  • adw-gtk3
  • ags
  • alisthelper
  • alisthelper.debug
  • alisthelper.pubcache
  • bloomeetunes
  • bloomeetunes.debug
  • bloomeetunes.pubcache
  • bluebubbles
  • bluebubbles.debug
  • bluebubbles.pubcache
  • butterfly
  • butterfly.debug
  • butterfly.pubcache
  • chatmcp
  • chatmcp.debug
  • chatmcp.pubcache
  • convertall
  • convertall.debug
  • convertall.pubcache
  • cosmic-settings-daemon
  • cwtch-ui
  • cwtch-ui.debug
  • cwtch-ui.pubcache
  • dart-sass
  • dart-sass.pubcache
  • discourse
  • discourseAllPlugins
  • domine
  • domine.pubcache
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache
  • evolve-core
  • evolve-core.debug
  • evolve-core.pubcache
  • finamp
  • finamp.debug
  • finamp.pubcache
  • firmware-updater
  • firmware-updater.debug
  • firmware-updater.pubcache
  • flclash
  • flclash.debug
  • flclash.pubcache
  • flet-client-flutter
  • flet-client-flutter.debug
  • flet-client-flutter.pubcache
  • fluffychat
  • fluffychat-web
  • fluffychat-web.pubcache
  • fluffychat.debug
  • fluffychat.pubcache
  • flut-renamer
  • flut-renamer.debug
  • flut-renamer.pubcache
  • flutter (flutter332, flutterPackages-bin.stable, flutterPackages-bin.v3_32, flutterPackages.stable, flutterPackages.v3_32)
  • flutter324 (flutterPackages-bin.v3_24, flutterPackages.v3_24)
  • flutter327 (flutterPackages-bin.v3_27, flutterPackages.v3_27)
  • flutter329 (flutterPackages-bin.v3_29, flutterPackages.v3_29)
  • flutterPackages-source.v3_32 (flutterPackages-source.stable)
  • flutterPackages-source.v3_24
  • flutterPackages-source.v3_27
  • flutterPackages-source.v3_29
  • fvm
  • fvm.pubcache
  • gitlab
  • gitlab-ee
  • gopeed
  • gopeed.debug
  • gopeed.pubcache
  • gpt-box
  • gpt-box.debug
  • gpt-box.pubcache
  • harmony-music
  • harmony-music.debug
  • harmony-music.pubcache
  • hiddify-app
  • hiddify-app.debug
  • hiddify-app.pubcache
  • homer
  • hover
  • hyprpanel
  • intiface-central
  • intiface-central.debug
  • intiface-central.pubcache
  • jekyll
  • jellyflix
  • jellyflix.debug
  • jellyflix.pubcache
  • jhentai
  • jhentai.debug
  • jhentai.pubcache
  • jsonnet
  • jsonnet.doc
  • kazumi
  • kazumi.debug
  • kazumi.pubcache
  • libretrack
  • libretrack.debug
  • libretrack.pubcache
  • localsend
  • localsend.debug
  • localsend.pubcache
  • mangayomi
  • mangayomi.debug
  • mangayomi.pubcache
  • melos
  • melos.pubcache
  • multipass
  • musicpod
  • musicpod.debug
  • musicpod.pubcache
  • oneanime
  • oneanime.debug
  • oneanime.pubcache
  • pied
  • pied.debug
  • pied.pubcache
  • pilipalax
  • pilipalax.debug
  • pilipalax.pubcache
  • plant-it-frontend
  • plant-it-frontend.pubcache
  • protoc-gen-dart
  • protoc-gen-dart.pubcache
  • proxypin
  • proxypin.debug
  • proxypin.pubcache
  • python312Packages.flet-cli
  • python312Packages.flet-cli.dist
  • python312Packages.flet-desktop
  • python312Packages.flet-desktop.dist
  • python312Packages.flet-web
  • python312Packages.flet-web.dist
  • python313Packages.flet-cli
  • python313Packages.flet-cli.dist
  • python313Packages.flet-desktop
  • python313Packages.flet-desktop.dist
  • python313Packages.flet-web
  • python313Packages.flet-web.dist
  • quarto
  • quartoMinimal
  • quickgui
  • quickgui.debug
  • quickgui.pubcache
  • redisinsight
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache
  • saber
  • saber.debug
  • saber.pubcache
  • server-box
  • server-box.debug
  • server-box.pubcache
  • shopware-cli
  • sideswap
  • sideswap.debug
  • sideswap.pubcache
  • simple-live-app
  • simple-live-app.debug
  • simple-live-app.pubcache
  • sly
  • sly.debug
  • sly.pubcache
  • unsure
  • unsure.pubcache
  • venera
  • venera.debug
  • venera.pubcache
  • voicevox
  • vscode-runner
  • vscode-runner.pubcache
  • windsend
  • windsend.debug
  • windsend.pubcache
  • wox
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache
Error logs: `x86_64-linux`
expidus.calculator 
           
           #6      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           
           #7      FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:416:9)
           
           #8      AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)
           
           #9      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:364:5)
           
           #10     run.. (package:flutter_tools/runner.dart:130:9)
           
           #11     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)
           
           #12     main (package:flutter_tools/executable.dart:93:3)
           

[        ] Running 1 shutdown hook

[        ] Shutdown hooks complete

[   +1 ms] exiting with code 1

@philiptaron
Copy link
Contributor

philiptaron commented Jul 10, 2025

Expidus is irrelevant; I don't understand why it hasn't been removed yet.

Yes, that build failure occurs on master as well. Gitlab succeeded on rebuild.

@philiptaron philiptaron merged commit 3dd7bc3 into NixOS:master Jul 10, 2025
27 of 28 checks passed
@ghost ghost deleted the languageVersion branch July 10, 2025 23:02
@ghost ghost removed the request for review from hacker1024 July 11, 2025 19:45
@ghost ghost removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 11, 2025
@qzylinra qzylinra mentioned this pull request Sep 2, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pub2nix.generators.linkPackageConfig does not set the languageVersion for the root package

1 participant

@philiptaron