Skip to content

nvidia-container-toolkit: hardcode pname to string to improve readibility#414538

Closed
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
guylamar2006:refactor-nvidia-toolkit
Closed

nvidia-container-toolkit: hardcode pname to string to improve readibility#414538
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
guylamar2006:refactor-nvidia-toolkit

Conversation

@guylamar2006
Copy link
Contributor

Hardcode pname to string to improve readability, refactor meta section and change rev -> tag.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 6, 2025
@nix-owners nix-owners bot requested review from christoph-heiss and cpcloud June 6, 2025 14:58
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 414538

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/15493439182


x86_64-linux (sandbox = true)

✅ 9 packages built:
  • apptainer
  • apptainer-overriden-nixos
  • nvidia-container-toolkit
  • nvidia-container-toolkit.tools
  • nvidia-docker
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

aarch64-linux (sandbox = true)

✅ 9 packages built:
  • apptainer
  • apptainer-overriden-nixos
  • nvidia-container-toolkit
  • nvidia-container-toolkit.tools
  • nvidia-docker
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@guylamar2006 guylamar2006 force-pushed the refactor-nvidia-toolkit branch from 3dd8b5a to 7c0fcaf Compare June 16, 2025 20:33
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 16, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 14, 2025
@guylamar2006
Copy link
Contributor Author

Superseded by:
#410679
#417886

@guylamar2006 guylamar2006 deleted the refactor-nvidia-toolkit branch March 20, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants