Skip to content

ninja_1_11: backport patch for compat with Python 3.13#412706

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt:ninja-1.11-python-3.13
May 31, 2025
Merged

ninja_1_11: backport patch for compat with Python 3.13#412706
mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt:ninja-1.11-python-3.13

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented May 31, 2025

Replaces usage pipes.quote with shlex.quote.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Replaces usage pipes.quote with shlex.quote.
@mweinelt mweinelt requested review from reckenrode and stephank May 31, 2025 16:07
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 31, 2025
@nix-owners nix-owners bot requested review from bjornfor and thoughtpolice May 31, 2025 16:13
@bjornfor
Copy link
Contributor

Duplicate of #412687 (1 hour older PR 😄 )

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mweinelt mweinelt merged commit 6716ab6 into NixOS:staging-next May 31, 2025
16 of 19 checks passed
@mweinelt mweinelt deleted the ninja-1.11-python-3.13 branch May 31, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants