Skip to content

ninja_1_11: fix build with Python 3.13#412687

Closed
mdaniels5757 wants to merge 1 commit intoNixOS:staging-nextfrom
mdaniels5757:fix-ninja_1_11
Closed

ninja_1_11: fix build with Python 3.13#412687
mdaniels5757 wants to merge 1 commit intoNixOS:staging-nextfrom
mdaniels5757:fix-ninja_1_11

Conversation

@mdaniels5757
Copy link
Member

Python 3.13 removed the "pipes" module, which Ninja used through v1.12.0.

Current staging-next iteration PR: #412425

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Python 3.13 removed the "pipes" module, which Ninja used through v1.12.0.
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 31, 2025
@nix-owners nix-owners bot requested review from bjornfor and thoughtpolice May 31, 2025 15:09
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, I think #412706 should be merged instead, as it fetches the patch instead of inlining it.

@mweinelt mweinelt closed this May 31, 2025
@mdaniels5757 mdaniels5757 deleted the fix-ninja_1_11 branch May 31, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants