Skip to content

amazon-qldb-shell: drop#410413

Merged
Aleksanaa merged 3 commits intoNixOS:masterfrom
terlar:remove-qldb-related-packages
Aug 1, 2025
Merged

amazon-qldb-shell: drop#410413
Aleksanaa merged 3 commits intoNixOS:masterfrom
terlar:remove-qldb-related-packages

Conversation

@terlar
Copy link
Contributor

@terlar terlar commented May 24, 2025

Amazon is dropping support for Amazon QLDB and is not accepting any new customers, these packages have not received any updates upstream for years, (except pyqldb which received one yearly release up to last year before the deprecation).

I did not drop the supporting packages python3Packages.amazon-ion and python3Packages.jsonconversion as they are not directly related and still receives active development. Should we drop them as well as they are just libraries and don't support any packages currently?

Closes #409038

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 24, 2025
@nix-owners nix-owners bot requested a review from natsukium May 24, 2025 06:10
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 24, 2025
@patka-123 patka-123 added the 8.has: clean-up This PR removes packages or removes other cruft label May 24, 2025
@TomaSajt
Copy link
Contributor

I did not drop the supporting packages python3Packages.amazon-ion and python3Packages.jsonconversion as they are not directly related and still receives active development. Should we drop them as well as they are just libraries and don't support any packages currently?

IMO as long as they are properly maintained by upstream, we can keep them around.
Though I don't have a very strong opinion about this.

@FliegendeWurst
Copy link
Member

Merge conflict due to #410679

@pbsds
Copy link
Member

pbsds commented May 30, 2025

End of support notice: Existing customers will be able to use Amazon QLDB until end of support on 07/31/2025.

Sounds like a good date to merge this 👍
I'm in favor of keeping it around untill then to aid any users who want to leverage nixpkgs to egress

@pbsds
Copy link
Member

pbsds commented May 30, 2025

Since there already is a merge conflict i went ahead and merged #409038 in the meanwhile

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 9, 2025
@terlar terlar force-pushed the remove-qldb-related-packages branch from f29526d to a222b83 Compare July 3, 2025 11:22
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 3, 2025
@terlar terlar force-pushed the remove-qldb-related-packages branch from a222b83 to 68b930d Compare July 3, 2025 11:27
@terlar
Copy link
Contributor Author

terlar commented Jul 3, 2025

I have resolved the merge conflict now and updated the date in the drop comments.

The official deprecation date is closing in:
Amazon QLDB until end of support on 07/31/2025

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 9, 2025
@terlar terlar force-pushed the remove-qldb-related-packages branch from 68b930d to d22d723 Compare July 21, 2025 08:23
@terlar
Copy link
Contributor Author

terlar commented Jul 21, 2025

@pbsds I rebased this again.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 21, 2025
@terlar
Copy link
Contributor Author

terlar commented Jul 21, 2025

GitHub Actions seems to have some unrelated issues.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@terlar terlar force-pushed the remove-qldb-related-packages branch from d22d723 to c7d8639 Compare July 30, 2025 12:38
@terlar
Copy link
Contributor Author

terlar commented Jul 30, 2025

@wegank conflicts resolved again

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 30, 2025
@pbsds pbsds changed the title Drop Amazon QLDB related packages amazon-qldb-shell: drop Jul 31, 2025
@pbsds pbsds closed this Jul 31, 2025
@pbsds pbsds reopened this Jul 31, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 31, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Aug 1, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2490

@Aleksanaa Aleksanaa merged commit 02cba07 into NixOS:master Aug 1, 2025
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants