amazon-qldb-shell: don't vendor Cargo.lock#409038
Merged
pbsds merged 1 commit intoNixOS:masterfrom May 30, 2025
Merged
Conversation
Contributor
|
Thank you @TomaSajt, I have not used QLDB for a while and have thus been neglecting this package. I will approve this for now. But given QLDB is being deprecated I will start the process of removing these packages: |
terlar
approved these changes
May 24, 2025
Contributor
terlar
left a comment
There was a problem hiding this comment.
Verified that cargoHash is correct.
Contributor
|
Here is the PR removing the packages instead #410413 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important note: this package is currently broken. Of course you can set
NIXPKGS_ALLOW_BROKEN=1to try to build it anyway.This PR does not unbreak the package (I tried and failed).
It does, however, remove one of the few remaining lockfiles that were only vendored because they contain git dependencies, and not because upstream didn't provide them.
Those can now be un-vendored, since
fetchCargoVendorworks with git dependencies.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.