Skip to content

amazon-qldb-shell: don't vendor Cargo.lock#409038

Merged
pbsds merged 1 commit intoNixOS:masterfrom
TomaSajt:amazon-qldb-shell
May 30, 2025
Merged

amazon-qldb-shell: don't vendor Cargo.lock#409038
pbsds merged 1 commit intoNixOS:masterfrom
TomaSajt:amazon-qldb-shell

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented May 20, 2025

Important note: this package is currently broken. Of course you can set NIXPKGS_ALLOW_BROKEN=1 to try to build it anyway.

This PR does not unbreak the package (I tried and failed).
It does, however, remove one of the few remaining lockfiles that were only vendored because they contain git dependencies, and not because upstream didn't provide them.
Those can now be un-vendored, since fetchCargoVendor works with git dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2025
@nix-owners nix-owners bot requested a review from terlar May 20, 2025 11:31
@terlar
Copy link
Contributor

terlar commented May 24, 2025

Thank you @TomaSajt, I have not used QLDB for a while and have thus been neglecting this package. I will approve this for now.

But given QLDB is being deprecated I will start the process of removing these packages:
https://docs.aws.amazon.com/qldb/latest/developerguide/document-history.html

Copy link
Contributor

@terlar terlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that cargoHash is correct.

@terlar
Copy link
Contributor

terlar commented May 24, 2025

Here is the PR removing the packages instead #410413

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 24, 2025
@FliegendeWurst FliegendeWurst mentioned this pull request May 30, 2025
13 tasks
@pbsds pbsds merged commit f28c7e1 into NixOS:master May 30, 2025
28 of 29 checks passed
@TomaSajt TomaSajt deleted the amazon-qldb-shell branch June 19, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants