Skip to content

riko4: drop#408328

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
LordGrimmauld:riko-drop
May 18, 2025
Merged

riko4: drop#408328
Aleksanaa merged 1 commit intoNixOS:masterfrom
LordGrimmauld:riko-drop

Conversation

@LordGrimmauld
Copy link
Contributor

The package in nixpkgs was basically unmaintained since 2018. It's maintainer in nixpkgs is inactive since 2022. It dependended on the already dropped SDL_gpu package, which it pinned internally. This now also started failing to build.
While upstream has a newer version of riko4 available, it does not remove the SDL_gpu dependency or fix its issues.

part of #403336
part of #388196
cc @NixOS/sdl

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The package in nixpkgs was basically unmaintained since 2018.
It's maintainer in nixpkgs is inactive since 2022.
It dependended on the already dropped SDL_gpu package, which it pinned internally.
This now also started failing to build.
While upstream has a newer version of `riko4` available,
it does not remove the SDL_gpu dependency or fix its issues.
@LordGrimmauld
Copy link
Contributor Author

Can't even review-request the maintainer, so: cc @CrazedProgrammer

@LordGrimmauld LordGrimmauld added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 8.has: clean-up This PR removes packages or removes other cruft labels May 18, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 18, 2025
@LordGrimmauld
Copy link
Contributor Author

Oh and, the sdl-gpu drop with reasoning: #390204

@Aleksanaa Aleksanaa merged commit 273359d into NixOS:master May 18, 2025
22 of 24 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 18, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 8.has: clean-up This PR removes packages or removes other cruft 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants