Merged
Conversation
The package in nixpkgs was basically unmaintained since 2018. It's maintainer in nixpkgs is inactive since 2022. It dependended on the already dropped SDL_gpu package, which it pinned internally. This now also started failing to build. While upstream has a newer version of `riko4` available, it does not remove the SDL_gpu dependency or fix its issues.
Contributor
Author
|
Can't even review-request the maintainer, so: cc @CrazedProgrammer |
marcin-serwin
approved these changes
May 18, 2025
Contributor
Author
|
Oh and, the sdl-gpu drop with reasoning: #390204 |
jansol
approved these changes
May 18, 2025
Contributor
|
Successfully created backport PR for |
1 task
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package in nixpkgs was basically unmaintained since 2018. It's maintainer in nixpkgs is inactive since 2022. It dependended on the already dropped SDL_gpu package, which it pinned internally. This now also started failing to build.
While upstream has a newer version of
riko4available, it does not remove the SDL_gpu dependency or fix its issues.part of #403336
part of #388196
cc @NixOS/sdl
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.