Merged
Conversation
Contributor
Author
|
github-actions
bot
added
10.rebuild-darwin: 0
AndersonTorres
approved these changes
Mar 15, 2025
LordGrimmauld
added
the
8.has: clean-up
FliegendeWurst
requested changes
Mar 15, 2025
Member
FliegendeWurst
left a comment
FliegendeWurst
left a comment
There was a problem hiding this comment.
You need to add an entry in pkgs/top-level/aliases.nix. Other than that I think it's okay to remove
LordGrimmauld
force-pushed
the
drop-sdl_cpu
branch
from
2b4d142 to
8422966
Compare
FliegendeWurst
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library was intended for gpu-accelerated 2d graphics. However, it is currently broken in nixpkgs.
upstream has seen no commits or new pull requests in the past three years. @pmiddend originally packaged this back in 2019, the package then got occasional maintenance from @AndersonTorres . @pmiddend was removed as a maintainer in #308379 (232ab40) due to inactivity at the time. Since then, the package was mostly stale, seeing the occasional treewide. It also broke on clang for a time, and was fixed during zero-hydra-failures push for 24.11.
Just recently, the package broke again due to gcc14, see #388196. Other than the big tracking issue, it was not even noticed to be failing! In the context of #389106 i was poking at various SDL things, and saw this failure pop up in various places.
It is questionable whether there is any users of this remaining. The package has no dependents, is stale and broken. I vote for removal, but am willing to hear if people actually use this. Though be aware any user might well have to fix upstream to even be compatible with gcc14.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.