Closed
Conversation
Now that libGLU is `null` on macOS (NixOS#400427), the `install_name_tool` command was being passed `-add_rpath` without an actual path argument after it, and was throwing an error as a result. This change filters out any `null`s from `buildInputs` before building the command line.
github-actions
bot
added
10.rebuild-darwin: 11-100
13 tasks
Member
|
Contributor
Author
|
Just realized that #405305 already handles this build failure a different way. Should we close this in favor of that one? |
Contributor
|
Imo yes this should be closed - ultimately, the previous rpath things were hacks, and there is better ways to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that libGLU is
nullon macOS (#400427), theinstall_name_toolcommand was being passed-add_rpathwithout an actual path argument after it, and was throwing an error as a result. This change filters out anynulls frombuildInputsbefore building the command line.ZHF: #403336
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.