Skip to content

SDL_compat: mark broken on darwin#404948

Closed
willcohen wants to merge 1 commit intoNixOS:masterfrom
willcohen:sdl-darwin
Closed

SDL_compat: mark broken on darwin#404948
willcohen wants to merge 1 commit intoNixOS:masterfrom
willcohen:sdl-darwin

Conversation

@willcohen
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 7, 2025
@willcohen
Copy link
Contributor Author

Noted during nixpkgs-review of #380263. Already broken on master, but darwin still tries to rebuild unsuccessfully on bump of binaryen and emscripten.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2025
@willcohen
Copy link
Contributor Author

Relevant for #403336

@Rhys-T
Copy link
Contributor

Rhys-T commented May 9, 2025

If this is about the install_name_tool failure, I just tracked that down and submitted a fix in #405464 (not reviewed yet).

Edit: And then realized that #405305 makes it redundant.

@LordGrimmauld
Copy link
Contributor

I'll close this in favor of #405305. No good reason to mark something broken that can be fixed.

@willcohen
Copy link
Contributor Author

Thank you — sorry for missing.

@willcohen willcohen deleted the sdl-darwin branch May 9, 2025 15:35
@LordGrimmauld
Copy link
Contributor

All good, the fix was opened after the mark-broken was opened. And even if that weren't the case, you broke nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants