Closed
Conversation
Member
|
2.0.0 is in master now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped silverbullet, but tests are failing and not sure how to proceed.
First things first, this is a deno app. When I initially bumped the version and built, it was trying to download dependencies at runtime. I found out that the
silverbullet.jsthat is provided on the release page is compiled with this behavior explicitly. Currently, this PR lets silverbullet create a temporary cache directory in/tmp, but this is less than ideal and also doesn't fix the tests. It'd be very challenging to build this in Nix, so I'm leaning towards making a couple issues on the original repo: 1) provide a deno.lock and 2) remove runtime evaluated dependencies.Any feedback would be greatly appreciated.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.