Skip to content

silverbullet: 0.9.4 -> 0.10.4#404225

Closed
costowell wants to merge 1 commit intoNixOS:masterfrom
costowell:nixos-unstable
Closed

silverbullet: 0.9.4 -> 0.10.4#404225
costowell wants to merge 1 commit intoNixOS:masterfrom
costowell:nixos-unstable

Conversation

@costowell
Copy link

Bumped silverbullet, but tests are failing and not sure how to proceed.
First things first, this is a deno app. When I initially bumped the version and built, it was trying to download dependencies at runtime. I found out that the silverbullet.js that is provided on the release page is compiled with this behavior explicitly. Currently, this PR lets silverbullet create a temporary cache directory in /tmp, but this is less than ideal and also doesn't fix the tests. It'd be very challenging to build this in Nix, so I'm leaning towards making a couple issues on the original repo: 1) provide a deno.lock and 2) remove runtime evaluated dependencies.

Any feedback would be greatly appreciated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 4, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 4, 2025
@phaer phaer mentioned this pull request Sep 8, 2025
13 tasks
@phaer
Copy link
Member

phaer commented Sep 9, 2025

2.0.0 is in master now :)

@phaer phaer closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants