Skip to content

silverbullet: 0.9.4 -> 0.10.4#356163

Closed
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/silverbullet
Closed

silverbullet: 0.9.4 -> 0.10.4#356163
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/silverbullet

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/silverbulletmd/silverbullet/releases.

meta.description for silverbullet is: Open-source, self-hosted, offline-capable Personal Knowledge Management (PKM) web application

meta.homepage for silverbullet is: https://silverbullet.md

meta.changelog for silverbullet is: https://github.com/silverbulletmd/silverbullet/blob/0.10.1/website/CHANGELOG.md

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS

Caution

A test defined in passthru.tests did not pass.

  • found 0.10.1 with grep in /nix/store/sfdw65hgizcwvhmgdvn5mprlc8d0hcr2-silverbullet-0.10.1
  • found 0.10.1 in filename of file in /nix/store/sfdw65hgizcwvhmgdvn5mprlc8d0hcr2-silverbullet-0.10.1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

silverbullet
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/sfdw65hgizcwvhmgdvn5mprlc8d0hcr2-silverbullet-0.10.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A silverbullet https://github.com/r-ryantm/nixpkgs/archive/f37b12f441bf386e4e71004a700c38de8f12ca7e.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/f37b12f441bf386e4e71004a700c38de8f12ca7e#silverbullet

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/sfdw65hgizcwvhmgdvn5mprlc8d0hcr2-silverbullet-0.10.1
ls -la /nix/store/sfdw65hgizcwvhmgdvn5mprlc8d0hcr2-silverbullet-0.10.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • silverbullet

Maintainer pings

cc @aorith for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@aorith
Copy link
Member

aorith commented Nov 15, 2024

Since the update to support deno 2, the app needs to manage a cache dir for remote deno packages ...
Sadly, the tests won't pass since network isn't available there.
Atm I'm not sure how to solve this.

This fixes the service for the default silverbullet user:

index a6a830e674b4..0d5ab8df1e83 100644
--- a/nixos/modules/services/web-apps/silverbullet.nix
+++ b/nixos/modules/services/web-apps/silverbullet.nix
@@ -100,6 +100,8 @@ in
         User = "${cfg.user}";
         Group = "${cfg.group}";
         EnvironmentFile = lib.mkIf (cfg.envFile != null) "${cfg.envFile}";
+        Environment = lib.mkIf (lib.hasPrefix "/var/lib/" cfg.spaceDir) "DENO_DIR=/var/cache/silverbullet/deno";
+        CacheDirectory = "silverbullet";
         StateDirectory = lib.mkIf (lib.hasPrefix "/var/lib/" cfg.spaceDir) (lib.last (lib.splitString "/" cfg.spaceDir));
         ExecStart = "${lib.getExe cfg.package} --port ${toString cfg.listenPort} --hostname '${cfg.listenAddress}' '${cfg.spaceDir}' " + lib.concatStringsSep " " cfg.extraArgs;
         Restart = "on-failure";

Cache dir after startup:

[root@arcadia:~]# ls -lrt /var/cache/silverbullet/deno/
total 32072
drwxr-xr-x 2 silverbullet silverbullet     4096 nov 15 14:13 npm
-rw-r--r-- 1 silverbullet silverbullet     4096 nov 15 14:13 node_analysis_cache_v2
-rw-r--r-- 1 silverbullet silverbullet     4096 nov 15 14:13 dep_analysis_cache_v2
-rw-r--r-- 1 silverbullet silverbullet    32768 nov 15 14:13 dep_analysis_cache_v2-shm
-rw-r--r-- 1 silverbullet silverbullet    32768 nov 15 14:13 v8_code_cache_v2-shm
-rw-r--r-- 1 silverbullet silverbullet    41232 nov 15 14:13 node_analysis_cache_v2-wal
-rw-r--r-- 1 silverbullet silverbullet    32768 nov 15 14:13 node_analysis_cache_v2-shm
drwxr-xr-x 3 silverbullet silverbullet     4096 nov 15 14:13 remote
drwxr-xr-x 3 silverbullet silverbullet     4096 nov 15 14:14 gen
-rw-r--r-- 1 silverbullet silverbullet 15278080 nov 15 14:14 v8_code_cache_v2
-rw-r--r-- 1 silverbullet silverbullet  1998232 nov 15 14:14 dep_analysis_cache_v2-wal
-rw-r--r-- 1 silverbullet silverbullet 15400592 nov 15 14:14 v8_code_cache_v2-wal

If someone wants to upgrade to this version overriding the package, it will need the cache-dir:

    systemd.services.silverbullet.serviceConfig = {
      Environment = "DENO_DIR=/var/cache/silverbullet/deno";
      CacheDirectory = "silverbullet";
    };

But we'll need to find another way to package this.
Probably a deno builder like #326003

@aorith aorith self-assigned this Nov 15, 2024
@aorith aorith added the 0.kind: regression Something that worked before working no longer label Nov 15, 2024
@ofborg ofborg bot requested a review from aorith November 15, 2024 22:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 15, 2024
@wolfgangwalther wolfgangwalther marked this pull request as draft December 8, 2024 15:47
@wolfgangwalther wolfgangwalther added the 9.needs: human intervention There were changes that bots cannot deal with. label Dec 8, 2024
@sanzoghenzo
Copy link
Contributor

If someone wants to upgrade to this version overriding the package, it will need the cache-dir:

    systemd.services.silverbullet.serviceConfig = {
      Environment = "DENO_DIR=/var/cache/silverbullet/deno";
      CacheDirectory = "silverbullet";
    };

Thanks for the info!
I also had to set the path for the KV database to avoid read-only errors (by default, it uses the working directory)

SB_KV_DB=/var/lib/silverbullet/silverbullet.db

@r-ryantm r-ryantm changed the title silverbullet: 0.9.4 -> 0.10.1 silverbullet: 0.9.4 -> 0.10.4 Mar 2, 2025
@r-ryantm
Copy link
Contributor Author

r-ryantm commented Mar 2, 2025

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/silverbulletmd/silverbullet/releases.

meta.description for silverbullet is: Open-source, self-hosted, offline-capable Personal Knowledge Management (PKM) web application

meta.homepage for silverbullet is: https://silverbullet.md

meta.changelog for silverbullet is: https://github.com/silverbulletmd/silverbullet/blob/0.10.4/website/CHANGELOG.md

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS

Caution

A test defined in passthru.tests did not pass.

  • found 0.10.4 with grep in /nix/store/7df62x4ca5dp94h4awv5mgj7lb4jcj9b-silverbullet-0.10.4
  • found 0.10.4 in filename of file in /nix/store/7df62x4ca5dp94h4awv5mgj7lb4jcj9b-silverbullet-0.10.4

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

silverbullet
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/7df62x4ca5dp94h4awv5mgj7lb4jcj9b-silverbullet-0.10.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A silverbullet https://github.com/r-ryantm/nixpkgs/archive/217562dd1a35bfc2c88a1bb5fce7cd1131eb7d88.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/217562dd1a35bfc2c88a1bb5fce7cd1131eb7d88#silverbullet

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/7df62x4ca5dp94h4awv5mgj7lb4jcj9b-silverbullet-0.10.4
ls -la /nix/store/7df62x4ca5dp94h4awv5mgj7lb4jcj9b-silverbullet-0.10.4/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • silverbullet

Maintainer pings

cc @aorith for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@r-ryantm r-ryantm force-pushed the auto-update/silverbullet branch from f37b12f to 217562d Compare March 2, 2025 08:59
@natecox
Copy link

natecox commented Jun 10, 2025

Any update on this? Looks like it's been sitting for a while.

@eduarrrd
Copy link
Contributor

eduarrrd commented Aug 5, 2025

Drive-by: There are at least two first-time contributors wasted on this PR:

@thegu5 thegu5 mentioned this pull request Aug 7, 2025
13 tasks
@ddogfoodd
Copy link
Contributor

Now there's a new release: https://github.com/silverbulletmd/silverbullet/releases/tag/2.0.0

@phaer phaer mentioned this pull request Sep 8, 2025
13 tasks
@phaer phaer closed this Sep 9, 2025
@r-ryantm r-ryantm deleted the auto-update/silverbullet branch September 9, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: regression Something that worked before working no longer 9.needs: human intervention There were changes that bots cannot deal with. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants