{fetchnextcloudapp,varnish60Packages}: fix meta inheritance#402180
Merged
numinit merged 2 commits intoNixOS:masterfrom Apr 27, 2025
Merged
{fetchnextcloudapp,varnish60Packages}: fix meta inheritance#402180numinit merged 2 commits intoNixOS:masterfrom
numinit merged 2 commits intoNixOS:masterfrom
Conversation
Another edge case of NixOS#400458. Reported-by: jopejoe1 <jopejoe1@missing.ninja> Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Another edge case of NixOS#400458. Reported-by: jopejoe1 <jopejoe1@missing.ninja> Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
github-actions
bot
added
the
6.topic: fetch
13 tasks
numinit
approved these changes
Apr 27, 2025
Contributor
numinit
left a comment
numinit
left a comment
There was a problem hiding this comment.
Basically identical to my changes but you covered all the other Varnish files too.
github-actions
bot
added
10.rebuild-darwin: 0
numinit
added
0.kind: bug
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two edge cases from #400458. These packages should really be included in the default Nixpkgs evaluation.
cc @jopejoe1, @numinit
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.