treewide: switch instances of lib.teams.*.members to the new meta.teams attribute

[SigmaSquadron]

Follow-up to #394797.

This is my first treewide, and I don't think I broke anything, but I would appreciate a thorough review.

Things done

• Evaluated on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[numinit]

(Note that none of my comments are intended to be blockers at all -- it evals and the maintainer diff looks good to me!)

[numinit]

Just did the diff with the tool you used to triple check (I just used a diff -u before):

$ json-diff ./result/old-maintainer-results ./result/new-maintainer-results  > diff2
$ sha256sum diff1 diff2
9bdce99657f532062d7cbf2e4b21b7b2cd452e4db5522e98d586b7d161873b5d  diff1
9bdce99657f532062d7cbf2e4b21b7b2cd452e4db5522e98d586b7d161873b5d  diff2

[numinit]

In the interest of getting in before the next merge conflict... time to use meta.teams in the relevant packages I touch next 🫡

[jopejoe1]

This broke eval of packages under nextcloud30Packages.apps with:

error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at /nix/store/7lrywm0zarcd43mbdw93j03yl2n57ik6-source/pkgs/servers/nextcloud/packages/default.nix:52:11:
           51|           pname: data:
           52|           self.mkNextcloudDerivation {
             |           ^
           53|             inherit pname data;

       … while calling a functor (an attribute set with a '__functor' attribute)
         at /nix/store/7lrywm0zarcd43mbdw93j03yl2n57ik6-source/pkgs/servers/nextcloud/packages/default.nix:31:9:
           30|         { pname, data }:
           31|         pkgs.fetchNextcloudApp {
             |         ^
           32|           appName = pname;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: function 'anonymous lambda' called with unexpected argument 'teams'
       at /nix/store/7lrywm0zarcd43mbdw93j03yl2n57ik6-source/pkgs/build-support/fetchnextcloudapp/default.nix:8:1:
            7| }:
            8| {
             | ^
            9|   url,

and also of varnish60Packages.{digest,dynamic,modules}:

error:
       … in the condition of the assert statement
         at /nix/store/pskdfhj9vaw5q9ixfw3mcaqivx212n11-source/lib/customisation.nix:419:9:
          418|       drvPath =
          419|         assert condition;
             |         ^
          420|         drv.drvPath;

       … while evaluating 'validity' to select 'handled' on it
         at /nix/store/pskdfhj9vaw5q9ixfw3mcaqivx212n11-source/pkgs/stdenv/generic/make-derivation.nix:733:22:
          732|
          733|     extendDerivation validity.handled (
             |                      ^
          734|       {

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'maintainers' missing
       at /nix/store/pskdfhj9vaw5q9ixfw3mcaqivx212n11-source/pkgs/servers/varnish/digest.nix:50:46:
           49|     homepage = "https://github.com/varnish/libvmod-digest";
           50|     inherit (varnish.meta) license platforms maintainers;
             |                                              ^
           51|   };

[magneticflux-]

@jopejoe1 I think this should work, it just didn't match any previous use patterns.

diff --git a/pkgs/build-support/fetchnextcloudapp/default.nix b/pkgs/build-support/fetchnextcloudapp/default.nix
index ccc079b70204..31f35c0568d3 100644
--- a/pkgs/build-support/fetchnextcloudapp/default.nix
+++ b/pkgs/build-support/fetchnextcloudapp/default.nix
@@ -16,6 +16,7 @@
   description ? null,
   homepage ? null,
   maintainers ? [ ],
+  teams ? [ ],
   unpack ? false, # whether to use fetchzip rather than fetchurl
 }:
 applyPatches (
@@ -27,7 +28,7 @@ applyPatches (
         {
           license = lib.licenses.${license};
           longDescription = description;
-          inherit homepage maintainers;
+          inherit homepage maintainers teams;
         }
         // lib.optionalAttrs (description != null) {
           longDescription = description;

[khaneliman]

Nixos package search doesn't pull the teams members anymore, so now there are lots of packages with missing maintainer information.

[JohnRTitor]

We need to PR for nixos-search.

[RossComputerGuy]

Already mentioned, NixOS/nixos-search#914. This PR just needs someone who is knowledgeable with NixOS search to figure out how to test it.

[khaneliman]

Already mentioned, NixOS/nixos-search#914. This PR just needs someone who is knowledgeable with NixOS search to figure out how to test it.

Sorry, was hidden by github...

[RossComputerGuy]

Repology now has a PR to make things visible again repology/repology-updater#1492