mx-discord-puppet: use yarn-berry, unbreak with newer nodejs#401889
Closed
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
Closed
mx-discord-puppet: use yarn-berry, unbreak with newer nodejs#401889TomaSajt wants to merge 3 commits intoNixOS:masterfrom
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
Conversation
Diff: https://cyberchaos.dev/yuka/yarn-berry-fetcher/-/compare/1.0.1...1.1.0 Implemented support for __archiveUrl bindings
Contributor
|
I have no opinion on whether this should be merged or not, but nice that you got it to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #401813
CC: @yuyuyureka
This build also needed patchShebangs in the hook. (for node-gyp).
Not sure if this PR should be merged:
The package has been broken for a long time, not just after the nodejs_18 removal.
There are no maintainers and I have no plans to maintain it.
However, this was good practice with using the yarn-berry tooling, so it's not a waste of time.
Note: a nixos module uses this package
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.