Skip to content

yarn-berry.yarn-berry-fetcher: 1.0.1 -> 1.2.1#401813

Merged
yuyuyureka merged 2 commits intoNixOS:masterfrom
yuyuyureka:yarn-berry-fetcher-1-1-0
Apr 26, 2025
Merged

yarn-berry.yarn-berry-fetcher: 1.0.1 -> 1.2.1#401813
yuyuyureka merged 2 commits intoNixOS:masterfrom
yuyuyureka:yarn-berry-fetcher-1-1-0

Conversation

@yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Apr 25, 2025

Diff: https://cyberchaos.dev/yuka/yarn-berry-fetcher/-/compare/1.0.1...1.2.1?w=1

  • Implemented support for __archiveUrl bindings
  • Solved performance issues with many small files
  • Improved help output (By @euank)

Also split the "yarn install" in yarnBerryConfigHook in two parts, and added a patchShebangs in between, similar to how npmConfigHook does it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yuyuyureka yuyuyureka marked this pull request as ready for review April 25, 2025 17:06
@yuyuyureka yuyuyureka requested a review from TomaSajt April 25, 2025 17:06
@yuyuyureka yuyuyureka mentioned this pull request Apr 25, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 25, 2025
@yuyuyureka yuyuyureka force-pushed the yarn-berry-fetcher-1-1-0 branch from 9bebb44 to 2130d99 Compare April 26, 2025 08:19
Diff: https://cyberchaos.dev/yuka/yarn-berry-fetcher/-/compare/1.0.1...1.2.1?w=1

- Implemented support for __archiveUrl bindings
- Solved performance issues with many small files
- Improved help output (By @euank)
@yuyuyureka yuyuyureka force-pushed the yarn-berry-fetcher-1-1-0 branch from 2130d99 to 4cdd7fd Compare April 26, 2025 08:35
@yuyuyureka yuyuyureka changed the title yarn-berry.yarn-berry-fetcher: 1.0.1 -> 1.1.0 yarn-berry.yarn-berry-fetcher: 1.0.1 -> 1.2.1 Apr 26, 2025
@yuyuyureka yuyuyureka force-pushed the yarn-berry-fetcher-1-1-0 branch from 4cdd7fd to 1184732 Compare April 26, 2025 08:42
@yuyuyureka yuyuyureka requested review from euank and flokli April 26, 2025 08:42
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 26, 2025
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yuyuyureka yuyuyureka merged commit 42bb244 into NixOS:master Apr 26, 2025
31 of 35 checks passed
@yuyuyureka yuyuyureka deleted the yarn-berry-fetcher-1-1-0 branch April 26, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants