Skip to content

nixVersions.nix_2_28: 2.28.1 -> 2.28.2#401038

Merged
Mic92 merged 2 commits intoNixOS:release-24.11from
Mic92:nix-2.28-24.11
Apr 25, 2025
Merged

nixVersions.nix_2_28: 2.28.1 -> 2.28.2#401038
Mic92 merged 2 commits intoNixOS:release-24.11from
Mic92:nix-2.28-24.11

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 23, 2025

Diff: NixOS/nix@2.28.1...2.28.2

Backport of #400262

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested review from Artturin and lovesegfault April 23, 2025 06:50
@misuzu
Copy link
Contributor

misuzu commented Apr 24, 2025

2.28.2 contains regression: NixOS/nix#13050

@Mic92
Copy link
Member Author

Mic92 commented Apr 24, 2025

Pushed the fix. But I think we actually want to wait for NixOS/nix#13082

@Mic92
Copy link
Member Author

Mic92 commented Apr 25, 2025

Pushed the fix. But I think we actually want to wait for NixOS/nix#13082

Actually, I want to take NixOS/nix#13082 a bit slower i.e. also add a regression test to it. For the other fixes we have in 2.28.2, I think it would be still worth to go ahead merging this.

@Mic92
Copy link
Member Author

Mic92 commented Apr 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401038 --package nix


x86_64-linux

✅ 5 packages built:
  • nix
  • nix.debug (nix.debug.debug, nix.debug.dev, nix.debug.doc, nix.debug.man)
  • nix.dev (nix.dev.debug, nix.dev.dev, nix.dev.doc, nix.dev.man)
  • nix.doc (nix.doc.debug, nix.doc.dev, nix.doc.doc, nix.doc.man)
  • nix.man (nix.man.debug, nix.man.dev, nix.man.doc, nix.man.man)

aarch64-linux

✅ 5 packages built:
  • nix
  • nix.debug (nix.debug.debug, nix.debug.dev, nix.debug.doc, nix.debug.man)
  • nix.dev (nix.dev.debug, nix.dev.dev, nix.dev.doc, nix.dev.man)
  • nix.doc (nix.doc.debug, nix.doc.dev, nix.doc.doc, nix.doc.man)
  • nix.man (nix.man.debug, nix.man.dev, nix.man.doc, nix.man.man)

x86_64-darwin

✅ 4 packages built:
  • nix
  • nix.dev (nix.dev.dev, nix.dev.doc, nix.dev.man)
  • nix.doc (nix.doc.dev, nix.doc.doc, nix.doc.man)
  • nix.man (nix.man.dev, nix.man.doc, nix.man.man)

aarch64-darwin

✅ 4 packages built:
  • nix
  • nix.dev (nix.dev.dev, nix.dev.doc, nix.dev.man)
  • nix.doc (nix.doc.dev, nix.doc.doc, nix.doc.man)
  • nix.man (nix.man.dev, nix.man.doc, nix.man.man)

@Mic92 Mic92 merged commit a41851f into NixOS:release-24.11 Apr 25, 2025
24 of 27 checks passed
@Mic92 Mic92 deleted the nix-2.28-24.11 branch April 25, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants