Skip to content

nixVersions.nix_2_28: 2.28.1 -> 2.28.2#400262

Merged
roberth merged 2 commits intomasterfrom
nix2282
Apr 22, 2025
Merged

nixVersions.nix_2_28: 2.28.1 -> 2.28.2#400262
roberth merged 2 commits intomasterfrom
nix2282

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 20, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 20, 2025
@nix-owners nix-owners bot requested review from Artturin and lovesegfault April 20, 2025 05:36
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ofborg passes.
No changes in upstream packaging.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 20, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 21, 2025
@roberth roberth merged commit 7582a31 into master Apr 22, 2025
46 checks passed
@zowoq zowoq deleted the nix2282 branch April 22, 2025 23:34
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 23, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-400262-to-release-24.11 origin/release-24.11
cd .worktree/backport-400262-to-release-24.11
git switch --create backport-400262-to-release-24.11
git cherry-pick -x 756dda5cd13a59177ed8dfca8a0b4f5db12b1da1 e5b760b14f736e3f26fd351b619dd775ec963515

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2025

#401038

Mic92 pushed a commit that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants