Skip to content

heroic: bump electron version #400790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomaSajt merged 2 commits into from
Apr 24, 2025
Merged

heroic: bump electron version #400790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc6e3c
heroic: bump electron version
aidalgol Apr 22, 2025
4f25858
heroic: simplify code to make node-gyp run offline
aidalgol Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions pkgs/by-name/he/heroic-unwrapped/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
python3,
makeWrapper,
# Upstream uses EOL Electron 31. Use next oldest version.
electron_33,
electron_34,
vulkan-helper,
gogdl,
legendary-heroic,
Expand All @@ -17,7 +17,7 @@
}:

let
electron = electron_33;
electron = electron_34;
in
stdenv.mkDerivation (finalAttrs: {
pname = "heroic-unwrapped";
Expand Down Expand Up @@ -53,11 +53,7 @@ stdenv.mkDerivation (finalAttrs: {
runHook preBuild

# set nodedir to prevent node-gyp from downloading headers
# taken from https://nixos.org/manual/nixpkgs/stable/#javascript-tool-specific
mkdir -p $HOME/.node-gyp/${nodejs.version}
echo 9 > $HOME/.node-gyp/${nodejs.version}/installVersion
ln -sfv ${nodejs}/include $HOME/.node-gyp/${nodejs.version}
export npm_config_nodedir=${nodejs}
export npm_config_nodedir=${electron.headers}

pnpm --offline electron-vite build
pnpm --offline electron-builder \
Expand Down