Skip to content

heroic: bump electron version#400790

Merged
TomaSajt merged 2 commits intoNixOS:masterfrom
aidalgol:heroic-electron-bump
Apr 24, 2025
Merged

heroic: bump electron version#400790
TomaSajt merged 2 commits intoNixOS:masterfrom
aidalgol:heroic-electron-bump

Conversation

@aidalgol
Copy link
Contributor

Pinned Electron version is EOL soon. Prompted by #397918.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Pinned Electron version is EOL soon.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@TomaSajt
Copy link
Contributor

Just as a semi-related cleanup, you could also use the more correct headers for rebuilding the native deps

-    # taken from https://nixos.org/manual/nixpkgs/stable/#javascript-tool-specific
-    mkdir -p $HOME/.node-gyp/${nodejs.version}
-    echo 9 > $HOME/.node-gyp/${nodejs.version}/installVersion
-    ln -sfv ${nodejs}/include $HOME/.node-gyp/${nodejs.version}
-    export npm_config_nodedir=${nodejs}
+    export npm_config_nodedir=${electron.headers}

(I'm not sure what the first few lines actually achieved, it seemed to work without it)

Co-authored-by: TomaSajt <62384384+TomaSajt@users.noreply.github.com>
@aidalgol
Copy link
Contributor Author

@TomaSajt Thanks! I've committed and pushed that change.

@aidalgol aidalgol requested review from K900 and TomaSajt April 24, 2025 21:31
@TomaSajt
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 400790

Logs: https://github.com/TomaSajt/nixpkgs-review-gha/actions/runs/14652473257


x86_64-linux

✅ 2 packages built:
  • heroic
  • heroic-unwrapped

@TomaSajt TomaSajt merged commit 157e85b into NixOS:master Apr 24, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants