heroic: bump electron version#400790
Merged
TomaSajt merged 2 commits intoNixOS:masterfrom Apr 24, 2025
aidalgol:heroic-electron-bump
Merged
heroic: bump electron version#400790TomaSajt merged 2 commits intoNixOS:masterfrom aidalgol:heroic-electron-bump
TomaSajt merged 2 commits intoNixOS:masterfrom
aidalgol:heroic-electron-bump
Conversation
Pinned Electron version is EOL soon.
22 tasks
Contributor
|
Just as a semi-related cleanup, you could also use the more correct headers for rebuilding the native deps - # taken from https://nixos.org/manual/nixpkgs/stable/#javascript-tool-specific
- mkdir -p $HOME/.node-gyp/${nodejs.version}
- echo 9 > $HOME/.node-gyp/${nodejs.version}/installVersion
- ln -sfv ${nodejs}/include $HOME/.node-gyp/${nodejs.version}
- export npm_config_nodedir=${nodejs}
+ export npm_config_nodedir=${electron.headers}(I'm not sure what the first few lines actually achieved, it seemed to work without it) |
Co-authored-by: TomaSajt <62384384+TomaSajt@users.noreply.github.com>
Contributor
Author
|
@TomaSajt Thanks! I've committed and pushed that change. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned Electron version is EOL soon. Prompted by #397918.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.