Skip to content

crystalline: 0.15.0 -> 0.17.1 with added updateScript #400558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kachick wants to merge 3 commits into from
+41 −8
Closed

crystalline: 0.15.0 -> 0.17.1 with added updateScript #400558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d558a
crystalline: add updateScript
kachick Apr 21, 2025
3a7541c
crystalline: 0.15.0 -> 0.17.1
kachick Apr 21, 2025
3c3ff53
crystalline: add version test
kachick Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 41 additions & 3 deletions pkgs/development/tools/language-servers/crystalline/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,29 @@
fetchFromGitHub,
llvmPackages,
openssl,
shards,
makeWrapper,
_experimental-update-script-combinators,
crystal2nix,
runCommand,
writeShellScript,
gitUpdater,
testers,
crystalline,
}:

let
version = "0.15.0";
version = "0.17.1";
in
crystal.buildCrystalPackage {
crystal.buildCrystalPackage rec {
pname = "crystalline";
inherit version;

src = fetchFromGitHub {
owner = "elbywan";
repo = "crystalline";
rev = "v${version}";
hash = "sha256-6ZAogEuOJH1QQ6NSJ+8KZUSFSgQAcvd4U9vWNAGix/M=";
hash = "sha256-SIfInDY6KhEwEPZckgobOrpKXBDDd0KhQt/IjdGBhWo=";
};

format = "crystal";
Expand All @@ -28,6 +36,7 @@ crystal.buildCrystalPackage {
llvmPackages.llvm
openssl
makeWrapper
shards
];

doCheck = false;
Expand All @@ -47,6 +56,35 @@ crystal.buildCrystalPackage {
wrapProgram "$out/bin/crystalline" --prefix PATH : '${lib.makeBinPath [ llvmPackages.llvm.dev ]}'
'';

passthru = {
updateScript = _experimental-update-script-combinators.sequence [
(gitUpdater { rev-prefix = "v"; })
(_experimental-update-script-combinators.copyAttrOutputToFile "crystalline.shardLock" "${builtins.toString ./.}/shard.lock")
{
command = [
(writeShellScript "update-lock" "cd $1; ${lib.getExe crystal2nix}")
./.
];
supportedFeatures = [ "silent" ];
}
{
command = [
"rm"
"${builtins.toString ./.}/shard.lock"
];
supportedFeatures = [ "silent" ];
}
];
shardLock = runCommand "shard.lock" { inherit src; } ''
cp $src/shard.lock $out
'';

# Since doInstallCheck causes another test error, versionCheckHook is avoided.
Copy link
Member Author

@kachick kachick Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When enabled doInstallCheck, it caused following error

stdenv-linux/setup: line 1763
"unary operator expected"

It seems like a same error of #242681 (comment)

tests.version = testers.testVersion {
package = crystalline;
};
};

meta = {
description = "Language Server Protocol implementation for Crystal";
mainProgram = "crystalline";
Expand Down
5 changes: 0 additions & 5 deletions pkgs/development/tools/language-servers/crystalline/shards.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,4 @@
rev = "e448ce83486f99ef016c311e10ec0cac805cded3";
sha256 = "13yp7805xpd605jpfpb3srqb0psy25w7n6x9mpkcyvzhqmpnpfyq";
};
version_from_shard = {
url = "https://github.com/hugopl/version_from_shard.git";
rev = "v1.2.5";
sha256 = "0xizj0q4rd541rwjbx04cjifc2gfx4l5v6q2y7gmd0ndjmkgb8ik";
};
}
Loading