crystalline: 0.15.0 -> 0.17.1 with added updateScript#400558
Closed
kachick wants to merge 3 commits intoNixOS:masterfrom
Closed
crystalline: 0.15.0 -> 0.17.1 with added updateScript#400558kachick wants to merge 3 commits intoNixOS:masterfrom
kachick wants to merge 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
Member
Author
|
kachick
commented
Aug 26, 2025
| cp $src/shard.lock $out | ||
| ''; | ||
|
|
||
| # Since doInstallCheck causes another test error, versionCheckHook is avoided. |
Member
Author
There was a problem hiding this comment.
When enabled doInstallCheck, it caused following error
stdenv-linux/setup: line 1763
"unary operator expected"
It seems like a same error of #242681 (comment)
nixpkgs-ci
bot
added
the
2.status: merge conflict
When enabled doInstallCheck, it causes following error ``` stdenv-linux/setup: line 1763 "unary operator expected" ```
kachick
force-pushed
the
update-crystalline
branch
from
2cd8d6e to
3c3ff53
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Member
Author
|
Closing this PR because there has been no feedback from the package maintainer. |
Member
|
Apologies for never getting around to this. I no longer use Crystal(line) and wasn't comfortable with pushing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: elbywan/crystalline@v0.15.0...v0.17.1
--versionflag since elbywan/crystalline@a761ed9Strictly speaking, crystalline 0.17 is supposed to be compatible with Crystal 1.16, but as I understand it, there is already a discrepancy—crystalline is currently at version 0.15, which corresponds to Crystal 1.14.
With that in mind, I wasn’t sure whether I should wait for this PR to be merged before submitting mine.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)cc: @donovanglover
Add a 👍 reaction to pull requests you find important.