Skip to content

postgresqlPackages: refactor finalAttrs support#398194

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-final-attrs
Apr 13, 2025
Merged

postgresqlPackages: refactor finalAttrs support#398194
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-final-attrs

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Apr 12, 2025

Rebuilds are caused by not passing enableUpdateScript through, anymore.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 12, 2025
@wolfgangwalther wolfgangwalther force-pushed the postgresql-final-attrs branch from 514bb1d to 0525472 Compare April 12, 2025 19:14
@wolfgangwalther wolfgangwalther marked this pull request as ready for review April 12, 2025 19:16
@nix-owners nix-owners bot requested review from Ma27 and thoughtpolice April 12, 2025 19:18
@wolfgangwalther
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398194


x86_64-linux

✅ 38 packages built:
  • postgresql13JitPackages.age
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_hint_plan
  • postgresql13JitPackages.pgaudit
  • postgresql13Packages.age
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_hint_plan
  • postgresql13Packages.pgaudit
  • postgresql14JitPackages.age
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_hint_plan
  • postgresql14JitPackages.pgaudit
  • postgresql14Packages.age
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_hint_plan
  • postgresql14Packages.pgaudit
  • postgresql15JitPackages.age
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.pg_hint_plan
  • postgresql15JitPackages.pgaudit
  • postgresql15Packages.age
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.pg_hint_plan
  • postgresql15Packages.pgaudit
  • postgresql16JitPackages.age
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.pg_hint_plan
  • postgresql16JitPackages.pgaudit
  • postgresql16Packages.age
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.pg_hint_plan
  • postgresql16Packages.pgaudit
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.pg_hint_plan (postgresql17JitPackages.pg_hint_plan)
  • postgresqlJitPackages.pgaudit (postgresql17JitPackages.pgaudit)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.pg_hint_plan (postgresql17Packages.pg_hint_plan)
  • postgresqlPackages.pgaudit (postgresql17Packages.pgaudit)

aarch64-linux

✅ 38 packages built:
  • postgresql13JitPackages.age
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_hint_plan
  • postgresql13JitPackages.pgaudit
  • postgresql13Packages.age
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_hint_plan
  • postgresql13Packages.pgaudit
  • postgresql14JitPackages.age
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_hint_plan
  • postgresql14JitPackages.pgaudit
  • postgresql14Packages.age
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_hint_plan
  • postgresql14Packages.pgaudit
  • postgresql15JitPackages.age
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.pg_hint_plan
  • postgresql15JitPackages.pgaudit
  • postgresql15Packages.age
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.pg_hint_plan
  • postgresql15Packages.pgaudit
  • postgresql16JitPackages.age
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.pg_hint_plan
  • postgresql16JitPackages.pgaudit
  • postgresql16Packages.age
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.pg_hint_plan
  • postgresql16Packages.pgaudit
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.pg_hint_plan (postgresql17JitPackages.pg_hint_plan)
  • postgresqlJitPackages.pgaudit (postgresql17JitPackages.pgaudit)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.pg_hint_plan (postgresql17Packages.pg_hint_plan)
  • postgresqlPackages.pgaudit (postgresql17Packages.pgaudit)

x86_64-darwin

✅ 38 packages built:
  • postgresql13JitPackages.age
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_hint_plan
  • postgresql13JitPackages.pgaudit
  • postgresql13Packages.age
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_hint_plan
  • postgresql13Packages.pgaudit
  • postgresql14JitPackages.age
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_hint_plan
  • postgresql14JitPackages.pgaudit
  • postgresql14Packages.age
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_hint_plan
  • postgresql14Packages.pgaudit
  • postgresql15JitPackages.age
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.pg_hint_plan
  • postgresql15JitPackages.pgaudit
  • postgresql15Packages.age
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.pg_hint_plan
  • postgresql15Packages.pgaudit
  • postgresql16JitPackages.age
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.pg_hint_plan
  • postgresql16JitPackages.pgaudit
  • postgresql16Packages.age
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.pg_hint_plan
  • postgresql16Packages.pgaudit
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.pg_hint_plan (postgresql17JitPackages.pg_hint_plan)
  • postgresqlJitPackages.pgaudit (postgresql17JitPackages.pgaudit)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.pg_hint_plan (postgresql17Packages.pg_hint_plan)
  • postgresqlPackages.pgaudit (postgresql17Packages.pgaudit)

aarch64-darwin

✅ 38 packages built:
  • postgresql13JitPackages.age
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_hint_plan
  • postgresql13JitPackages.pgaudit
  • postgresql13Packages.age
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_hint_plan
  • postgresql13Packages.pgaudit
  • postgresql14JitPackages.age
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_hint_plan
  • postgresql14JitPackages.pgaudit
  • postgresql14Packages.age
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_hint_plan
  • postgresql14Packages.pgaudit
  • postgresql15JitPackages.age
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.pg_hint_plan
  • postgresql15JitPackages.pgaudit
  • postgresql15Packages.age
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.pg_hint_plan
  • postgresql15Packages.pgaudit
  • postgresql16JitPackages.age
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.pg_hint_plan
  • postgresql16JitPackages.pgaudit
  • postgresql16Packages.age
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.pg_hint_plan
  • postgresql16Packages.pgaudit
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.pg_hint_plan (postgresql17JitPackages.pg_hint_plan)
  • postgresqlJitPackages.pgaudit (postgresql17JitPackages.pgaudit)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.pg_hint_plan (postgresql17Packages.pg_hint_plan)
  • postgresqlPackages.pgaudit (postgresql17Packages.pgaudit)

Copy link
Member

@diogotcorreia diogotcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfgangwalther wolfgangwalther merged commit 4ad1a0e into NixOS:master Apr 13, 2025
78 of 79 checks passed
@wolfgangwalther wolfgangwalther deleted the postgresql-final-attrs branch April 13, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants