buildPgrxExtension: restructure with lib.extendMkDerivation#394089
Conversation
If you change GitHub's diff settings to "hide whitespace", the second commit becomes empty. Thus, you don't need to split the first two - reviewing the whole PR with "hide whitespace" works very well. |
c474d09 to
6b9ebe5
Compare
|
@wolfgangwalther TIL, thanks for telling me, squashed the two commits |
|
I plan to look at this, but I am not familiar with |
wolfgangwalther
left a comment
There was a problem hiding this comment.
Let's refactor the remaining 3-4 pgrx packages to use finalAttrs, too - shouldn't be too much effort.
In #398194, I refactored all those with postgresqlBuildExtension, combined with this we'd have all of them :)
Support fixed-point arguments with lib.extendMkDerivation
6b9ebe5 to
b50641e
Compare
|
Done :) |
This PR enables
buildPgrxExtensionto takefinalAttrs: { ... }with the help oflib.extendMkDerivationintroduced in #234651.I migrated theAll cargo-pgrx extensions have been migratedpgvecto-rsextension to validate the implementation.The PR should yield no rebuilds.
Related discussion: #392710 (comment)
cc @wolfgangwalther
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.