canon-cups-ufr2: Fix gcc rpath for libstdc++#397705
Merged
phaer merged 1 commit intoNixOS:masterfrom May 4, 2025
Merged
Conversation
The rpath for libstdc++ was previously set to gcc's lib64 directory. That symlink was removed in NixOS#380325, breaking the programs and libraries distributed as binaries. Also stop using lib64 for libc, in case that symlink will be removed sometime in the future. Fixes NixOS#396654
Contributor
Author
|
@anna328p please have a look whether that fixes printing for you. I don't run unstable on my print server. |
github-actions
bot
added
10.rebuild-darwin: 0
Member
Will let you know whenever I get a chance to test it. Thank you so much! |
|
I've tested it; it works. |
Member
|
I just managed to update my system, will try it out now |
Member
|
It worked!! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpath for libstdc++ was previously set to gcc's lib64 directory. That symlink was removed in #380325, breaking the programs and libraries distributed as binaries. Also stop using lib64 for libc, in case that symlink will be removed sometime in the future.
Fixes #396654
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.