Skip to content

goshs: init at 1.0.2#396568

Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:goshs
Closed

goshs: init at 1.0.2#396568
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:goshs

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Apr 6, 2025

HTTP Server

https://github.com/patrickhener/goshs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 6, 2025
@fabaff
Copy link
Member Author

fabaff commented Apr 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396568


x86_64-linux

✅ 1 package built:
  • goshs

doInstallCheck = true;

meta = {
description = "HTTP Server";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "HTTP Server";
description = "Simple yet feature-rich web server";

I feel like the description should be something more than just "HTTP Server"? I grabbed this line from their website

@haylinmoore
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 396568

Logs: https://github.com/haylinmoore/nixpkgs-review-gha/actions/runs/14294007592


x86_64-linux

✅ 1 package built:
  • goshs

aarch64-linux

✅ 1 package built:
  • goshs

x86_64-darwin

❌ 1 package failed to build:
  • goshs

aarch64-darwin

❌ 1 package failed to build:
  • goshs

@ilarvne
Copy link
Member

ilarvne commented Apr 6, 2025

Hi @fabaff, thanks for contribution!
It looks like this PR is a duplicate of #366872

@lucasew
Copy link
Contributor

lucasew commented Apr 7, 2025

Hi @fabaff, thanks for contribution! It looks like this PR is a duplicate of #366872

But updated, we can close that once this is merged

@haylinmoore
Copy link
Contributor

Hi @fabaff, thanks for contribution! It looks like this PR is a duplicate of #366872

Given the lack of forward progress on the other PR, letting this one proceed and then closing the other if/when this merges make the most sense to me? I sent a message in the other PR to check for signs of life.

@haylinmoore haylinmoore mentioned this pull request Apr 9, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants