Skip to content

goshs: init at 1.0.2#366872

Merged
matthiasbeyer merged 2 commits intoNixOS:masterfrom
SEIAROTg:goshs-init
Apr 17, 2025
Merged

goshs: init at 1.0.2#366872
matthiasbeyer merged 2 commits intoNixOS:masterfrom
SEIAROTg:goshs-init

Conversation

@SEIAROTg
Copy link
Member

Adds package goshs, the simple, yet feature-rich web server.

See:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 20, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 21, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 21, 2024
@lucasew
Copy link
Contributor

lucasew commented Dec 21, 2024

Just for curiosity sake, what this does that rclone doesn't do?

Rclone has rclone serve http and rclone serve webdav that does basically the same thing.

@SEIAROTg
Copy link
Member Author

@lucasew

Just for curiosity sake, what this does that rclone doesn't do?

I was really looking for a really simple file upload portal but it turns out surprisingly hard.

  • filestash, projectsend: too heavy.
  • rclone serve, simple-http-server, etc.: no web ui for upload.
  • jirafeau, privatebin, most pastebin-alikes: can't upload multiple files.
  • psitransfer: files have to expire.
  • linx-server: modifies file name (underscore, case).

This is the only thing works for me so far (except it doesn't handle file timestamp but nor does most alternatives I've seen so far).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these ldflags?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two flags disable symbol generation and DWARF generation respectively and are AFAICT fairly standard for release-build Go packages. No need to strip them out later if we never generate them to begin with

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainers = [ lib.maintainers.seiarotg ];

@lucasew
Copy link
Contributor

lucasew commented Dec 22, 2024

@ofborg eval

@lucasew
Copy link
Contributor

lucasew commented Dec 22, 2024

Weird

@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 23, 2024
@donovanglover donovanglover marked this pull request as draft February 1, 2025 12:10
@ilarvne ilarvne mentioned this pull request Apr 6, 2025
13 tasks
@haylinmoore
Copy link
Contributor

Hiya, has there been any progress on this?

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody wants to continue on this PR, I'd take over until the end of the week and finish it.

@SEIAROTg
Copy link
Member Author

SEIAROTg commented Apr 8, 2025

Sorry didn't make much progress as I ended up running most stuff in container. Will finalize in the coming days.

@haylinmoore @matthiasbeyer do you want to be included in maintainers?

@haylinmoore
Copy link
Contributor

haylinmoore commented Apr 9, 2025

There is another open PR #396568 for it, so if you don't want to finish it you could probably just close the PR and have the other one continue.

@ilarvne would make more sense as a maintainer than me, as they are the author of the other PR

@matthiasbeyer
Copy link
Contributor

do you want to be included in maintainers?

yes please

@SEIAROTg SEIAROTg changed the title goshs: init at 1.0.1 goshs: init at 1.0.2 Apr 10, 2025
@SEIAROTg SEIAROTg force-pushed the goshs-init branch 2 times, most recently from 0de5393 to 94eaee6 Compare April 10, 2025 00:23
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Apr 10, 2025
@ilarvne
Copy link
Member

ilarvne commented Apr 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 366872

Logs: https://github.com/ilarvne/nixpkgs-review-gha/actions/runs/14370115656

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-366872-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://ilarvne.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      ilarvne.cachix.org-1:wgJB0Qc+6NHOsBj5r9HinhjrjH1TOIvGapUvCiej0L0=
      ' \
      /nix/store/d4k7y4nmcqmcbs1m6w9wizmz7cw737zp-goshs-1.0.2
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-366872-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://ilarvne.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      ilarvne.cachix.org-1:wgJB0Qc+6NHOsBj5r9HinhjrjH1TOIvGapUvCiej0L0=
      ' \
      /nix/store/6dafqfivgnpgkni6kjfdy6zl87d2b0qd-goshs-1.0.2
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-366872-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://ilarvne.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      ilarvne.cachix.org-1:wgJB0Qc+6NHOsBj5r9HinhjrjH1TOIvGapUvCiej0L0=
      ' \
      /nix/store/df6q9cqc0jvg4rgma0r66a28p5rda86q-goshs-1.0.2
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-366872-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://ilarvne.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      ilarvne.cachix.org-1:wgJB0Qc+6NHOsBj5r9HinhjrjH1TOIvGapUvCiej0L0=
      ' \
      /nix/store/l953msrh9kjqz3lnlka9y65ckfddgcg2-goshs-1.0.2

x86_64-linux

✅ 1 package built:
  • goshs

aarch64-linux

✅ 1 package built:
  • goshs

x86_64-darwin

✅ 1 package built:
  • goshs

aarch64-darwin

✅ 1 package built:
  • goshs

@SEIAROTg SEIAROTg marked this pull request as ready for review April 10, 2025 01:23
@SEIAROTg SEIAROTg requested review from lucasew and pluiedev April 10, 2025 01:24
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Apr 10, 2025
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Apr 12, 2025
@matthiasbeyer
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366872


x86_64-linux

✅ 1 package built:
  • goshs

@matthiasbeyer matthiasbeyer merged commit b8dd760 into NixOS:master Apr 17, 2025
42 of 43 checks passed
@matthiasbeyer
Copy link
Contributor

Now let the update bot do its thing I guess 😆 because 1.0.3 just came out.

We will see... thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants