rke2: use finalAttrs to avoid let and rec bindings#393720
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Apr 7, 2025
Merged
rke2: use finalAttrs to avoid let and rec bindings#393720wolfgangwalther merged 1 commit intoNixOS:masterfrom
finalAttrs to avoid let and rec bindings#393720wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
zimbatm
approved these changes
Mar 27, 2025
Member
zimbatm
left a comment
zimbatm
left a comment
There was a problem hiding this comment.
nice, buildGoModule didn't s use to support this
wegank
added
the
12.approvals: 1
Contributor
|
Needs a rebase to resolve conflict. |
rorosen
force-pushed
the
rke2-use-final-attrs
branch
from
62fac51 to
f26dc46
Compare
rorosen
force-pushed
the
rke2-use-final-attrs
branch
from
f26dc46 to
cd10b44
Compare
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
Author
|
Thanks, conflicts are resolved |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Use
finalAttrsto avoidletandrecbindings. This was proposed in #379844 (comment), but wasn't supported at that time. However, with #390220 this is possible now.@zimbatm @stefan-bordei
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.