rke2: switch to minor release versions#379844
Merged
zimbatm merged 8 commits intoNixOS:masterfrom Feb 24, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Get the old version and use it in the update script, instead of using an unbound variable.
Things done: - Make the update script expect a minor version instead of a release channel - Remove unused variables from update script - Set aliases for stable and latest releases in update script - Use yq to create update script output - Update version documentation
Use the right rke2 package in testVersion, instead of using the rke2 package, which points to rke2_stable, for all tests.
The RKE2 testing channel no longer serves releases.
https://github.com/rancher/rke2/releases/tag/v1.31.5%2Brke2r1 Additionally, rke2_stable now is an alias to rke_1_31 as both are the same package.
https://github.com/rancher/rke2/releases/tag/v1.32.1%2Brke2r1 Additionally, rke2_latest now is an alias to rke2_1_32, as both are the same package.
rorosen
force-pushed
the
rke2-numbered-releases
branch
from
a1896d8 to
36cb383
Compare
zimbatm
approved these changes
Feb 24, 2025
Member
zimbatm
left a comment
zimbatm
left a comment
There was a problem hiding this comment.
just noticed this review was left open. sorry for the wait.
overall the change makes sense to me.
Member
There was a problem hiding this comment.
I guess buildGoModule doesn't support the (final: { ... }) style argument? This could avoid the let and rec bindings.
This is more of a styling issue, so not a blocker.
Contributor
Author
There was a problem hiding this comment.
Great idea but I think this isn't supported, at least I can't get it to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic idea of this contribution is to follow minor release versions of RKE2, instead of named release channels. However, the changes also include fixes in update and build scripts that I noticed along the way.
Here is roughly what I did:
rke2_stableandrke2_latestreleases in the update scriptrke2_testingas the release channel doesn't serve releasesrke2_1_32)Closes #379547
@zimbatm @stefan-bordei @mogeko @frederictobiasc
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.