icewm: 3.7.1 -> 3.7.3

[Yarny0]

Update IceWM to latest release. Also drop a patch (added here) which is part of the new version, and switch from rev to tag in fetchFromGitHub.

Release notes: https://github.com/ice-wm/icewm/releases/tag/3.7.3
Changes: ice-wm/icewm@3.7.1...3.7.3

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

More:

• nixosTests.{lightdm,sddm,xrdp} build/pass (these seem to use IceWM in one way or another)
• looks OK in qemu
• I still can not reproduce the problem from icewm: /etc/icewm/menu doesn’t add to the IceWM menu #385959 , so it's solved upstream now

nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" wants to rebuild 2k packages and was therefore skipped.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5361

[Yarny0]

Pushed update due to new IceWM release. Also rebased onto current nixos-unstable. All "Things done" from PR text are still valid, the tests in particluar still pass.

[Yarny0]

Rebased onto current nixos-unstable to fix the recent merge conflict caused by #396749 and #397016 . Inspired by those pull requests, I also added a commit that converts rev to tag just for IceWM.

All "Things done" from PR text are still valid, the tests in particluar still pass. Also, I ensured that fetching via tag yields the same source hashes: I changed them and then compared the "got:" hash in the error message with the original one.

[Yarny0]

For the record: There is no merge conflict (according to Github).

I don't know how to deal with the "failing check":

ofborg-eval: Commit not found

I hope that's not a blocker for this pull request.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/103

[doronbehar]

A simple git rebase against latest master seem to have fixed the merge conflict and other ofborg errors.

[Yarny0]

Thanks, @doronbehar !