Skip to content

icewm: 3.7.0 -> 3.7.1 & fix icon-less start menu entries#386156

Merged
pbsds merged 2 commits intoNixOS:masterfrom
Yarny0:icewm-update-fix-fdo
Mar 2, 2025
Merged

icewm: 3.7.0 -> 3.7.1 & fix icon-less start menu entries#386156
pbsds merged 2 commits intoNixOS:masterfrom
Yarny0:icewm-update-fix-fdo

Conversation

@Yarny0
Copy link
Contributor

@Yarny0 Yarny0 commented Mar 1, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

More:


Add a 👍 reaction to pull requests you find important.

Yarny0 added 2 commits March 1, 2025 18:32
NixOS#385959
bbidulock/icewm#794

Why is this patch fetched from the `bbidulock` repo and
not from the `ice-wm` repo which contains the release commit?
According to https://github.com/ice-wm/icewm/wiki ,
the `ice-wm` repo is only used for releases;
development happens in `bbidulock`.
Due to this, the commit that is to be fetched hasn't
reached `ice-wm` yet (at the time of this writing).
@Yarny0 Yarny0 force-pushed the icewm-update-fix-fdo branch from 8981296 to 8824a59 Compare March 1, 2025 17:45
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 1, 2025
@pbsbot
Copy link

pbsbot commented Mar 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386156


x86_64-linux

✅ 1 package built:
  • icewm

@pbsds pbsds merged commit d87aa95 into NixOS:master Mar 2, 2025
26 of 27 checks passed
@Yarny0 Yarny0 deleted the icewm-update-fix-fdo branch March 5, 2025 19:11
@Yarny0 Yarny0 mentioned this pull request Mar 26, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icewm: /etc/icewm/menu doesn’t add to the IceWM menu

3 participants