[Backport release-24.11] nuget-to-json: fix silent error after curl update#390936
Merged
corngood merged 2 commits intorelease-24.11from Mar 18, 2025
Merged
[Backport release-24.11] nuget-to-json: fix silent error after curl update#390936corngood merged 2 commits intorelease-24.11from
corngood merged 2 commits intorelease-24.11from
Conversation
(cherry picked from commit 2afe69aeebe6b6deb7de91f326b9149f608645ca) (cherry picked from commit 5918547)
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
GGG-KILLER
added
12.approvals: 1
GGG-KILLER
approved these changes
Mar 18, 2025
MattSturgeon
approved these changes
Mar 18, 2025
Contributor
There was a problem hiding this comment.
I think the CI wants the commit messages to remove references to 2afe69aeebe6b6deb7de91f326b9149f608645ca and 7a36c0ef0b08e07afec4f5300956941db2945efa, as I guess these are the original commits that won't end up being merged anymore.
Probably fine either way, since github should keep those commits available for lookup even unmerged.
Contributor
|
Looks like it isn't smart enough to pick the last commit hash in case a commit is cherry-picked multiple times. I chose to approve it anyways because I don't think that warrants blocking this PR, it's just a sanity check anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #390928.