Skip to content

nuget-to-json: fix silent error after curl update#390928

Merged
corngood merged 2 commits intoNixOS:masterfrom
gepbird:dotnet-fetch-deps-fix
Mar 18, 2025
Merged

nuget-to-json: fix silent error after curl update#390928
corngood merged 2 commits intoNixOS:masterfrom
gepbird:dotnet-fetch-deps-fix

Conversation

@gepbird
Copy link
Contributor

@gepbird gepbird commented Mar 18, 2025

Fixes #389194

Cherry-picked the relevant commits from #389338, as this bug affects everyone who tries to update or add dotnet packages. It can be frustrating and time consuming to track this down for people unaware of this bug, so this should be merged in a timely manner

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 2afe69aeebe6b6deb7de91f326b9149f608645ca)
Fixes: NixOS#389194
(cherry picked from commit 7a36c0ef0b08e07afec4f5300956941db2945efa)
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2025
@gepbird
Copy link
Contributor Author

gepbird commented Mar 18, 2025

Tested with $(nix-build -A vrcadvert.fetch-deps), exit code is 0 and deps.json gets regenerated

@GGG-KILLER GGG-KILLER added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 18, 2025
@corngood corngood merged commit 91f6018 into NixOS:master Mar 18, 2025
35 of 37 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 18, 2025

Successfully created backport PR for release-24.11:

@r-vdp
Copy link
Contributor

r-vdp commented Mar 18, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-support, nuget-to-json: --netrc passed to curl and no .netrc in $HOME causing fetch-deps failure

4 participants