Merged
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
4eebc9b to
dd7bf6b
Compare
SuperSandro2000
previously requested changes
Mar 19, 2025
1ec4aa7 to
af40b5c
Compare
Member
|
Sorry, I currently do not have the capacity to do a proper review 😓 |
af40b5c to
1ee2c1d
Compare
Aleksanaa
approved these changes
Apr 6, 2025
Aleksanaa
reviewed
Apr 6, 2025
9499d4a to
d65c076
Compare
Aleksanaa
approved these changes
Apr 12, 2025
Member
Aleksanaa
left a comment
There was a problem hiding this comment.
I would like to merge it first as the current one is just broken. Just some small suggestions.
Run autogen.sh to properly create i18n and l10n files.
d65c076 to
afd5a4b
Compare
Member
Author
|
Thanks! |
This was referenced Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the firewalld package, which will pave the way for my upcoming PR adding nixos modules.
It now works as expected.
Related: https://git.sr.ht/~prince213/firewalld-nix
Related: #165882.
Closes #293778.
Closes #369440.
Closes #371129.
To test the changes, build firewalld and firewalld-gui locally and run executables in bin, observe that they run without errors in aforementioned issues/PRs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.