Skip to content

Comments

firewalld: repackage#389437

Merged
Aleksanaa merged 13 commits intoNixOS:masterfrom
Prince213:firewalld-package
Apr 12, 2025
Merged

firewalld: repackage#389437
Aleksanaa merged 13 commits intoNixOS:masterfrom
Prince213:firewalld-package

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Mar 13, 2025

This PR fixes the firewalld package, which will pave the way for my upcoming PR adding nixos modules.
It now works as expected.

Related: https://git.sr.ht/~prince213/firewalld-nix
Related: #165882.

Closes #293778.
Closes #369440.
Closes #371129.

To test the changes, build firewalld and firewalld-gui locally and run executables in bin, observe that they run without errors in aforementioned issues/PRs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 13, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/200

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 15, 2025
@Prince213 Prince213 force-pushed the firewalld-package branch 2 times, most recently from 1ec4aa7 to af40b5c Compare March 24, 2025 15:57
@SuperSandro2000 SuperSandro2000 removed their request for review March 25, 2025 15:37
@SuperSandro2000
Copy link
Member

Sorry, I currently do not have the capacity to do a proper review 😓

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@Prince213 Prince213 force-pushed the firewalld-package branch from af40b5c to 1ee2c1d Compare April 5, 2025 05:08
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Apr 7, 2025
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 12, 2025
@Prince213 Prince213 requested a review from Aleksanaa April 12, 2025 06:31
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 12, 2025
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to merge it first as the current one is just broken. Just some small suggestions.

Run autogen.sh to properly create i18n and l10n files.
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on x86_64-linux

@Aleksanaa Aleksanaa merged commit 605b8e2 into NixOS:master Apr 12, 2025
24 of 27 checks passed
@Prince213
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firewalld fails to start: ImportError: cannot import name GLib, introspection typelib not found Firewalld broken due to nftables

5 participants