firewalld: Add NetworkManager as dependency#369440
Closed
kleifgch wants to merge 1 commit intoNixOS:masterfrom
Closed
firewalld: Add NetworkManager as dependency#369440kleifgch wants to merge 1 commit intoNixOS:masterfrom
kleifgch wants to merge 1 commit intoNixOS:masterfrom
Conversation
This is required for firewalld to interact with NetworkManager via libnm and PyGObject.
Contributor
|
Is that really just happening when having firewalld with GUI? Just asking as it's added as GUI only dependency, or was that an accident? |
Contributor
Author
|
Since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firewalld tries to use libnm via pygobject:
https://github.com/firewalld/firewalld/blob/c1c6441634b4e9874a945dfed3146a88e52aff92/src/firewall/core/fw_nm.py#L13-L23
That currently fails because the typelib is added to the wrapper.
To verify that networkmanager contains the correct file:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.