Skip to content

Comments

firewalld: Add NetworkManager as dependency#369440

Closed
kleifgch wants to merge 1 commit intoNixOS:masterfrom
kleifgch:firewalld-add-networmanager
Closed

firewalld: Add NetworkManager as dependency#369440
kleifgch wants to merge 1 commit intoNixOS:masterfrom
kleifgch:firewalld-add-networmanager

Conversation

@kleifgch
Copy link
Contributor

Firewalld tries to use libnm via pygobject:
https://github.com/firewalld/firewalld/blob/c1c6441634b4e9874a945dfed3146a88e52aff92/src/firewall/core/fw_nm.py#L13-L23
That currently fails because the typelib is added to the wrapper.
To verify that networkmanager contains the correct file:

$ nix build nixpkgs#networkmanager
$ ls result/lib/girepository-1.0
NM-1.0.typelib

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is required for firewalld to interact with NetworkManager via libnm
and PyGObject.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 30, 2024
@Shawn8901
Copy link
Contributor

Is that really just happening when having firewalld with GUI? Just asking as it's added as GUI only dependency, or was that an accident?

@kleifgch
Copy link
Contributor Author

Since gobject-introspection is also only added on withGui I assumed so

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 31, 2024
@Prince213 Prince213 mentioned this pull request Mar 13, 2025
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants