Merged
Conversation
Aleksanaa
reviewed
Mar 8, 2025
ethancedwards8
suggested changes
Mar 8, 2025
ac4566d to
921e688
Compare
ethancedwards8
approved these changes
Mar 8, 2025
Contributor
|
Thanks for picking this up!! |
Contributor
Author
|
Changes since 921e688d5ff0:
1: 921e688d5ff0 ! 1: c5f9d28a33f3 neonmodem: init at 1.0.6
@@ pkgs/by-name/ne/neonmodem/package.nix (new)
+ installShellFiles,
+}:
+
-+buildGoModule rec {
++buildGoModule (finalAttrs: {
+ pname = "neonmodem";
+ version = "1.0.6";
+
+ src = fetchFromGitHub {
+ owner = "mrusme";
+ repo = "neonmodem";
-+ tag = "v${version}";
++ tag = "v${finalAttrs.version}";
+ hash = "sha256-VLR6eicffA0IXVwEZMvgpm1kVmrLYVZOtq7MSy+vIw8=";
+ };
+
@@ pkgs/by-name/ne/neonmodem/package.nix (new)
+ description = "BBS-style TUI client for Discourse, Lemmy, Lobsters, and Hacker News";
+ homepage = "https://neonmodem.com";
+ downloadPage = "https://github.com/mrusme/neonmodem/releases";
-+ changelog = "https://github.com/mrusme/neonmodem/releases/tag/${src.tag}";
++ changelog = "https://github.com/mrusme/neonmodem/releases/tag/v${finalAttrs.version}";
+ license = lib.licenses.gpl3Only;
+ maintainers = with lib.maintainers; [ acuteaangle ];
+ mainProgram = "neonmodem";
+ };
-+}
++}) |
Aleksanaa
approved these changes
Jun 11, 2025
Aleksanaa
reviewed
Jun 11, 2025
Aleksanaa
reviewed
Jun 11, 2025
Adds Neon Modem Overdrive: a BBS-style TUI client for Discourse, Lemmy, Lobsters, and Hacker News. Homepage: https://neonmodem.com/ git: https://github.com/mrusme/neonmodem.git Co-authored-by: IogaMaster <iogamastercode@gmail.com> Resolves: NixOSgh-290386 Closes: NixOSgh-290467
Contributor
Author
|
e7b4e6e builds and runs on x86_64-linux; I can’t test darwin myself. |
Aleksanaa
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Neon Modem Overdrive: a BBS-style TUI client for Discourse, Lemmy, Lobsters, and Hacker News.
This is based on the previous PR by @IogaMaster.
I am unsure if they still want to be a maintainer for this package, so I removed them for now.
Homepage: https://neonmodem.com/
Source: https://github.com/mrusme/neonmodem.git
License: GPL-3.0-only
Resolves: gh-290386 (Package request)
Closes: gh-290467 (Previous PR)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.