Skip to content

neonmodem: init at 1.0.4#290467

Closed
IogaMaster wants to merge 1 commit intoNixOS:masterfrom
IogaMaster:neonmodem
Closed

neonmodem: init at 1.0.4#290467
IogaMaster wants to merge 1 commit intoNixOS:masterfrom
IogaMaster:neonmodem

Conversation

@IogaMaster
Copy link
Contributor

@IogaMaster IogaMaster commented Feb 21, 2024

https://github.com/mrusme/neonmodem
Closes #290386

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 21, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 290467 at 66563e1 run on x86_64-linux 1

1 package built successfully:
  • neonmodem

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about installing shell completions?

@@ -0,0 +1,28 @@
{ lib
, buildGoModule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format with the new formatter.

ldflags = [ "-s" "-w" ];

meta = with lib; {
description = "A BBS-style command line client for many backends";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A BBS-style command line client for many backends";
description = "BBS-style command line client for many backends";

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@acuteaangle
Copy link
Contributor

I am also interested in this package; is there anything I can do to help move this along?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 30, 2025
@FliegendeWurst
Copy link
Member

Yes, you could clone the branch and create another PR based on it.

@acuteaangle acuteaangle mentioned this pull request Mar 8, 2025
13 tasks
acuteaangle added a commit to acuteaangle/nixpkgs that referenced this pull request Jun 11, 2025
Adds Neon Modem Overdrive: a BBS-style TUI client for Discourse, Lemmy,
Lobsters, and Hacker News.

Homepage: https://neonmodem.com/
git: https://github.com/mrusme/neonmodem.git

Co-authored-by: IogaMaster <iogamastercode@gmail.com>
Resolves: NixOSgh-290386
Closes: NixOSgh-290467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: Neon Modem Overdrive

6 participants